Alphabetize bookmarks

Summary: The bookmarks would appear in different order upon reloading the app. Here I have a fixed order.

Reviewed By: jknoxville

Differential Revision: D16540496

fbshipit-source-id: ebc3e1065dbd2ae76b919a943c2cc7f81d857ca8
This commit is contained in:
Benjamin Elo
2019-07-29 04:20:45 -07:00
committed by Facebook Github Bot
parent fc28b904a0
commit 4372fccacc

View File

@@ -53,6 +53,10 @@ const BookmarksList = styled('div')({
}, },
}); });
const alphabetizeBookmarkCompare = (b1: Bookmark, b2: Bookmark) => {
return b1.uri < b2.uri ? -1 : b1.uri > b2.uri ? 1 : 0;
};
export default (props: Props) => { export default (props: Props) => {
const {bookmarks, onNavigate} = props; const {bookmarks, onNavigate} = props;
return ( return (
@@ -61,18 +65,22 @@ export default (props: Props) => {
<NoData grow>No Bookmarks</NoData> <NoData grow>No Bookmarks</NoData>
) : ( ) : (
<BookmarksList> <BookmarksList>
{[...bookmarks.values()].map(bookmark => ( {[...bookmarks.values()]
<div .sort(alphabetizeBookmarkCompare)
className="bookmark-container" .map(bookmark => (
role="button" <div
tabIndex={0} className="bookmark-container"
onClick={() => { role="button"
onNavigate(bookmark.uri); tabIndex={0}
}}> onClick={() => {
<div className="bookmark-common-name">{bookmark.commonName}</div> onNavigate(bookmark.uri);
<div className="bookmark-uri">{bookmark.uri}</div> }}>
</div> <div className="bookmark-common-name">
))} {bookmark.commonName}
</div>
<div className="bookmark-uri">{bookmark.uri}</div>
</div>
))}
</BookmarksList> </BookmarksList>
)} )}
</DetailSidebar> </DetailSidebar>