From 42b95c21eb049161dd3b633e367723651cab6bd2 Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Fri, 1 Sep 2023 09:43:21 -0700 Subject: [PATCH] Disable Fresco integration for now (#5101) Summary: [android][sample] Disable Fresco integration for now There's currently a startup crash https://gist.github.com/passy/3f6b5935d8f9171ea0d3d915857b9786 We'll need to wait for a new Fresco release. In the meantime, let's comment this out so we can still use the rest of the app. --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/flipper/pull/5101). * __->__ https://github.com/facebook/flipper/issues/5101 * https://github.com/facebook/flipper/issues/5100 Pull Request resolved: https://github.com/facebook/flipper/pull/5101 Reviewed By: lblasa Differential Revision: D48863903 Pulled By: passy fbshipit-source-id: 0cb9c6050cf70a989b11ca60b3019ebab104279f --- .../flipper/sample/RootComponentSpec.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/android/sample/src/main/java/com/facebook/flipper/sample/RootComponentSpec.java b/android/sample/src/main/java/com/facebook/flipper/sample/RootComponentSpec.java index 5c8a703a1..203537070 100644 --- a/android/sample/src/main/java/com/facebook/flipper/sample/RootComponentSpec.java +++ b/android/sample/src/main/java/com/facebook/flipper/sample/RootComponentSpec.java @@ -8,10 +8,8 @@ package com.facebook.flipper.sample; import android.content.Intent; -import android.net.Uri; import com.facebook.flipper.android.diagnostics.FlipperDiagnosticActivity; import com.facebook.flipper.sample.network.NetworkClient; -import com.facebook.fresco.vito.litho.FrescoVitoImage2; import com.facebook.litho.ClickEvent; import com.facebook.litho.Column; import com.facebook.litho.Component; @@ -124,12 +122,14 @@ public class RootComponentSpec { .marginDip(YogaEdge.ALL, 10) .textSizeSp(20) .clickHandler(RootComponent.triggerCrash(c))) - .child( - FrescoVitoImage2.create(c) - .uri(Uri.parse("https://fbflipper.com/img/icon.png")) - .marginDip(YogaEdge.ALL, 10) - .widthDip(150) - .heightDip(150)) + // TODO: Re-enable once we have a new Litho v0.48.0-compatible version of Fresco. + /*.child( + FrescoVitoImage2.create(c) + .uri(Uri.parse("https://fbflipper.com/img/icon.png")) + .marginDip(YogaEdge.ALL, 10) + .widthDip(150) + .heightDip(150))*/ + .build(); return VerticalScroll.create(c).childComponent(col).build();