Clean up old flipper rating system

Summary:
Found some unused code from the rating prototype before switching to itsr.
Deleting it.

Reviewed By: cekkaewnumchai

Differential Revision: D18298155

fbshipit-source-id: 3529db17494f4f5bf7d7841460203d1c3856299a

src/chrome/RatingButton.tsx

@@ -28,10 +28,6 @@ type PropsFromState = {
   sessionId: string | null;
 };
 
-type OwnProps = {
-  onRatingChanged: (rating: number) => void;
-};
-
 type State = {
   promptData: FeedbackPrompt | null;
   isShown: boolean;
@@ -287,14 +283,14 @@ class FeedbackComponent extends Component<
   }
 }
 
-class RatingButton extends Component<PropsFromState & OwnProps, State> {
+class RatingButton extends Component<PropsFromState, State> {
   state: State = {
     promptData: null,
     isShown: false,
     hasTriggered: false,
   };
 
-  constructor(props: PropsFromState & OwnProps) {
+  constructor(props: PropsFromState) {
     super(props);
     if (GK.get('flipper_rating')) {
       UserFeedback.getPrompt().then(prompt => {
@@ -378,6 +374,6 @@ class RatingButton extends Component<PropsFromState & OwnProps, State> {
   }
 }
 
-export default connect<{sessionId: string | null}, null, OwnProps, Store>(
+export default connect<{sessionId: string | null}, null, {}, Store>(
   ({application: {sessionId}}) => ({sessionId}),
 )(RatingButton);

src/chrome/TitleBar.tsx

@@ -15,7 +15,6 @@ import {
   toggleLeftSidebarVisible,
   toggleRightSidebarVisible,
   ACTIVE_SHEET_BUG_REPORTER,
-  setFlipperRating,
   ACTIVE_SHEET_SETTINGS,
 } from '../reducers/application';
 import {
@@ -69,7 +68,6 @@ type DispatchFromProps = {
   toggleLeftSidebarVisible: (visible?: boolean) => void;
   toggleRightSidebarVisible: (visible?: boolean) => void;
   setActiveSheet: (sheet: ActiveSheet) => void;
-  setFlipperRating: (rating: number) => void;
 };
 
 type StateFromProps = {
@@ -79,7 +77,6 @@ type StateFromProps = {
   rightSidebarAvailable: boolean;
   downloadingImportData: boolean;
   launcherMsg: LauncherMsg;
-  flipperRating: number | null;
   share: ShareType | null | undefined;
   navPluginIsActive: boolean;
 };
@@ -161,9 +158,7 @@ class TitleBar extends React.Component<Props, StateFromProps> {
           share != null ? share.statusComponent : undefined,
         )}
         <Spacer />
-        {config.showFlipperRating ? (
+        {config.showFlipperRating ? <RatingButton /> : null}
-          <RatingButton onRatingChanged={this.props.setFlipperRating} />
-        ) : null}
         <Version>{this.props.version + (isProduction() ? '' : '-dev')}</Version>
 
         {isAutoUpdaterEnabled() ? (
@@ -221,7 +216,6 @@ export default connect<StateFromProps, DispatchFromProps, OwnProps, State>(
       rightSidebarAvailable,
       downloadingImportData,
       launcherMsg,
-      flipperRating,
       share,
     },
     pluginStates,
@@ -232,7 +226,6 @@ export default connect<StateFromProps, DispatchFromProps, OwnProps, State>(
     rightSidebarAvailable,
     downloadingImportData,
     launcherMsg,
-    flipperRating,
     share,
     navPluginIsActive: Object.keys(pluginStates).some(key =>
       /#Navigation$/.test(key),
@@ -242,6 +235,5 @@ export default connect<StateFromProps, DispatchFromProps, OwnProps, State>(
     setActiveSheet,
     toggleLeftSidebarVisible,
     toggleRightSidebarVisible,
-    setFlipperRating,
   },
 )(TitleBar);

src/dispatcher/tracking.tsx

@@ -48,8 +48,6 @@ export default (store: Store, logger: Logger) => {
       clients,
     } = store.getState().connections;
 
-    const {flipperRating} = store.getState().application;
-
     if (!selectedDevice || !selectedPlugin) {
       return;
     }
@@ -73,7 +71,6 @@ export default (store: Store, logger: Logger) => {
       plugin: selectedPlugin,
       app,
       sdkVersion,
-      flipperRating,
     };
 
     // reset dropped frames counter

src/reducers/application.tsx

@@ -77,7 +77,6 @@ export type State = {
   serverPorts: ServerPorts;
   downloadingImportData: boolean;
   launcherMsg: LauncherMsg;
-  flipperRating: number | null;
   statusMessages: Array<string>;
   xcodeCommandLineToolsDetected: boolean;
 };
@@ -120,12 +119,6 @@ export type Action =
         message: string;
       };
     }
-  | {
-      type: 'SET_FLIPPER_RATING';
-      payload: {
-        rating: number;
-      };
-    }
   | {
       type: 'UNSET_SHARE';
     }
@@ -169,7 +162,6 @@ export const initialState: () => State = () => ({
     severity: 'warning',
     message: '',
   },
-  flipperRating: null,
   statusMessages: [],
   xcodeCommandLineToolsDetected: false,
 });
@@ -242,11 +234,6 @@ export default function reducer(
       ...state,
       launcherMsg: action.payload,
     };
-  } else if (action.type === 'SET_FLIPPER_RATING') {
-    return {
-      ...state,
-      flipperRating: action.payload.rating,
-    };
   } else if (action.type === 'SET_EXPORT_STATUS_MESSAGE') {
     if (state.share) {
       const {share} = state;
@@ -344,13 +331,6 @@ export const toggleRightSidebarAvailable = (payload?: boolean): Action => ({
   payload,
 });
 
-export const setFlipperRating = (rating: number): Action => ({
-  type: 'SET_FLIPPER_RATING',
-  payload: {
-    rating,
-  },
-});
-
 export const setExportURL = (result: string): Action => ({
   type: 'SET_EXPORT_URL',
   payload: result,

src/reducers/index.tsx

@@ -59,7 +59,7 @@ export type Actions =
   | {type: 'INIT'};
 
 export type State = {
-  application: ApplicationState & PersistPartial;
+  application: ApplicationState;
   connections: DevicesState & PersistPartial;
   pluginStates: PluginStatesState;
   notifications: NotificationsState & PersistPartial;
@@ -81,14 +81,7 @@ const settingsStorage = new JsonFileStorage(
 );
 
 export default combineReducers<State, Actions>({
-  application: persistReducer<ApplicationState, Actions>(
-    {
-      key: 'application',
-      storage,
-      whitelist: ['flipperRating'],
-    },
   application,
-  ),
   connections: persistReducer<DevicesState, Actions>(
     {
       key: 'connections',