jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename android internals

Browse Source 
Summary: Rename public method and internal references inside the android package to Flipper.

Reviewed By: jknoxville, priteshrnandgaonkar

Differential Revision: D10008330

fbshipit-source-id: fd9b8a54bc9766e2d10b10c9b428f62e0bc3224a
This commit is contained in:
Pascal Hartig
2018-09-24 07:27:54 -07:00
committed by Facebook Github Bot
parent 656f7cc626
commit 41adb3bdaa
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
android/src/main/java/com/facebook/flipper/android/AndroidFlipperClient.java
View File

@@ -18,7 +18,7 @@ import com.facebook.flipper.core.FlipperClient;
public final class AndroidFlipperClient {
private static boolean sIsInitialized = false;
private static FlipperThread sSonarThread;
private static FlipperThread sFlipperThread;
private static FlipperThread sConnectionThread;
private static final String[] REQUIRED_PERMISSIONS =
new String[] {"android.permission.INTERNET", "android.permission.ACCESS_WIFI_STATE"};
@@ -26,15 +26,15 @@ public final class AndroidFlipperClient {
public static synchronized FlipperClient getInstance(Context context) {
if (!sIsInitialized) {
checkRequiredPermissions(context);
sSonarThread = new FlipperThread("SonarEventBaseThread");
sSonarThread.start();
sConnectionThread = new FlipperThread("SonarConnectionThread");
sFlipperThread = new FlipperThread("FlipperEventBaseThread");
sFlipperThread.start();
sConnectionThread = new FlipperThread("FlipperConnectionThread");
sConnectionThread.start();
final Context app =
context.getApplicationContext() == null ? context : context.getApplicationContext();
FlipperClientImpl.init(
sSonarThread.getEventBase(),
sFlipperThread.getEventBase(),
sConnectionThread.getEventBase(),
getServerHost(app),
"Android",
@@ -60,7 +60,7 @@ public final class AndroidFlipperClient {
for (String permission : REQUIRED_PERMISSIONS) {
if (ContextCompat.checkSelfPermission(context, permission)
== PackageManager.PERMISSION_DENIED) {
Log.e("Sonar", String.format("App needs permission \"%s\" to work with sonar", permission));
Log.e("Flipper", String.format("App needs permission \"%s\" to work with sonar", permission));
}
}
}
@@ -96,7 +96,7 @@ public final class AndroidFlipperClient {
final int ip = info.getIpAddress();
return String.format("%d.%d.%d.2", (ip & 0xff), (ip >> 8 & 0xff), (ip >> 16 & 0xff));
} else {
// Running on physical device. Sonar desktop will run `adb reverse tcp:8088 tcp:8088`
// Running on physical device. Flipper desktop will run `adb reverse tcp:8088 tcp:8088`
return "localhost";
}
}

2
android/src/main/java/com/facebook/flipper/android/utils/FlipperUtils.java
View File

@@ -16,7 +16,7 @@ public final class FlipperUtils {
private FlipperUtils() {}
public static boolean shouldEnableSonar(Context context) {
public static boolean shouldEnableFlipper(Context context) {
return BuildConfig.IS_INTERNAL_BUILD && !isEndToEndTest() && isMainProcess(context);
}