jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Get MacOS dock icon

Browse Source 
Summary:
The icon was not shown in the past as it was indefinitely bouncing on the dock.

This is fixed now by asynchronously initiating the Node server process and then waiting until it becomes ready.

Reviewed By: passy

Differential Revision: D49907976

fbshipit-source-id: cdeaa578be42d9f5308e2e0df50872858b8248c3
This commit is contained in:
Lorenzo Blasa
2023-10-04 05:37:12 -07:00
committed by Facebook GitHub Bot
parent 34304300c8
commit 40939e1ae5
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/static/flipper-server-app-template/Flipper.app/Contents/Info.plist
View File

@@ -40,7 +40,5 @@
<true/>
<key>NSHighResolutionCapable</key>
<true/>
<key>LSUIElement</key>
<true/>
</dict>
</plist>

7
desktop/static/flipper-server-app-template/Flipper.app/Contents/MacOS/Flipper
View File

@@ -6,4 +6,9 @@ SERVER_RESOURCES="$SCRIPT_PATH/../Resources/server"
cd "$SERVER_RESOURCES" || exit 1
echo "Starting flipper-server ..."
"$NODE_PATH" . "$@"
"$NODE_PATH" . "$@" &
# Wait for the Flipper HTTP server to start listening
while ! curl -s http://localhost:52342 > /dev/null; do
sleep 1
done