From 406f2f47af7a3f87fbfe8e40c224fecc30539cbc Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Mon, 6 Apr 2020 06:19:07 -0700 Subject: [PATCH] Fix DMG publish by running publish step on Ubuntu (#984) Summary: The current upload process is broken because the publish step only works on Linux. This first uploads the binary to artifact storage, then downloads it on Linux and runs the publish step. Pull Request resolved: https://github.com/facebook/flipper/pull/984 Test Plan: @public https://github.com/facebook/flipper/pull/984/checks?check_run_id=563996817 Everything here works apart from the publish action which throws a 400, which is expected as there's no tag/release associated with the PR. We can only really test the entire thing on a new release. Reviewed By: nikoant Differential Revision: D20868825 Pulled By: passy fbshipit-source-id: 97304328ec7eb1243280ca7a9f26e8049869d33b --- .github/workflows/dmg-release.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/dmg-release.yml b/.github/workflows/dmg-release.yml index 0de6e0644..cccdd62b4 100644 --- a/.github/workflows/dmg-release.yml +++ b/.github/workflows/dmg-release.yml @@ -23,6 +23,21 @@ jobs: run: yarn build --mac --mac-dmg working-directory: ${{env.desktop-directory}} - name: Upload + uses: actions/upload-artifact@v1 + with: + name: 'Flipper-mac.dmg' + path: 'dist/Flipper-mac.dmg' + publish: + runs-on: ubuntu-latest + needs: build + + steps: + - name: Download + uses: actions/download-artifact@v1 + with: + name: 'Flipper-mac.dmg' + path: 'dist/Flipper-mac.dmg' + - name: Publish uses: skx/github-action-publish-binaries@master env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}