Make sure important errors are always shown to the user

Summary:
This diff makes sure that important errors are always shown to the user, such as an xcode version mismatch.

Also made some small styling improvements

Reviewed By: jknoxville

Differential Revision: D19660337

fbshipit-source-id: 24dfb4d98bfdd1666164403f87b6a4e1dc915ddb
This commit is contained in:
Michel Weststrate
2020-01-31 05:07:44 -08:00
committed by Facebook Github Bot
parent 5f5cb64753
commit 3f45414846
5 changed files with 32 additions and 17 deletions

View File

@@ -191,6 +191,7 @@ async function checkXcodeVersionMismatch(store: Store) {
message: errorMessage,
details:
"You might want to run 'sudo xcode-select -s /Applications/Xcode.app/Contents/Developer'",
urgent: true,
},
});
// Fire a console.error as well, so that it gets reported to the backend.

View File

@@ -46,10 +46,12 @@ export default (store: Store, logger: Logger) => {
err.code === 'EADDRINUSE'
? "Couldn't start websocket server. Looks like you have multiple copies of Flipper running."
: err.message || 'Unknown error';
const urgent = err.code === 'EADDRINUSE';
store.dispatch({
type: 'SERVER_ERROR',
payload: {message},
urgent,
});
});