Move most of plugin tests to flipper-frontend-core

Summary: See D37139129

Reviewed By: passy

Differential Revision: D37241829

fbshipit-source-id: d6bef24416e2b999d529fb6e275c64384c775c21

desktop/flipper-frontend-core/src/__tests__/plugins.node.tsx

@@ -0,0 +1,188 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+import {
+  getDynamicPlugins,
+  checkDisabled,
+  checkGK,
+  createRequirePluginFunction,
+  getLatestCompatibleVersionOfEachPlugin,
+} from '../plugins';
+import {BundledPluginDetails, InstalledPluginDetails} from 'flipper-common';
+import {_SandyPluginDefinition} from 'flipper-plugin';
+import {getRenderHostInstance} from '../RenderHost';
+
+let loadDynamicPluginsMock: jest.Mock;
+
+const sampleInstalledPluginDetails: InstalledPluginDetails = {
+  name: 'other Name',
+  version: '1.0.0',
+  specVersion: 2,
+  pluginType: 'client',
+  main: 'dist/bundle.js',
+  source: 'src/index.js',
+  id: 'Sample',
+  title: 'Sample',
+  dir: '/Users/mock/.flipper/thirdparty/flipper-plugin-sample',
+  entry: 'this/path/does not/exist',
+  isBundled: false,
+  isActivatable: true,
+};
+
+const sampleBundledPluginDetails: BundledPluginDetails = {
+  ...sampleInstalledPluginDetails,
+  id: 'SampleBundled',
+  isBundled: true,
+};
+
+beforeEach(() => {
+  loadDynamicPluginsMock = getRenderHostInstance().flipperServer.exec =
+    jest.fn();
+  loadDynamicPluginsMock.mockResolvedValue([]);
+});
+
+test('getDynamicPlugins returns empty array on errors', async () => {
+  loadDynamicPluginsMock.mockRejectedValue(new Error('ooops'));
+  const res = await getDynamicPlugins();
+  expect(res).toEqual([]);
+});
+
+test('checkDisabled', () => {
+  const disabledPlugin = 'pluginName';
+  const hostConfig = getRenderHostInstance().serverConfig;
+  const orig = hostConfig.processConfig;
+  try {
+    hostConfig.processConfig = {
+      ...orig,
+      disabledPlugins: [disabledPlugin],
+    };
+    const disabled = checkDisabled([]);
+
+    expect(
+      disabled({
+        ...sampleBundledPluginDetails,
+        name: 'other Name',
+        version: '1.0.0',
+      }),
+    ).toBeTruthy();
+    expect(
+      disabled({
+        ...sampleBundledPluginDetails,
+        name: disabledPlugin,
+        version: '1.0.0',
+      }),
+    ).toBeFalsy();
+  } finally {
+    hostConfig.processConfig = orig;
+  }
+});
+
+test('checkGK for plugin without GK', () => {
+  expect(
+    checkGK([])({
+      ...sampleBundledPluginDetails,
+      name: 'pluginID',
+      version: '1.0.0',
+    }),
+  ).toBeTruthy();
+});
+
+test('checkGK for passing plugin', () => {
+  expect(
+    checkGK([])({
+      ...sampleBundledPluginDetails,
+      name: 'pluginID',
+      gatekeeper: 'TEST_PASSING_GK',
+      version: '1.0.0',
+    }),
+  ).toBeTruthy();
+});
+
+test('checkGK for failing plugin', () => {
+  const gatekeepedPlugins: InstalledPluginDetails[] = [];
+  const name = 'pluginID';
+  const plugins = checkGK(gatekeepedPlugins)({
+    ...sampleBundledPluginDetails,
+    name,
+    gatekeeper: 'TEST_FAILING_GK',
+    version: '1.0.0',
+  });
+
+  expect(plugins).toBeFalsy();
+  expect(gatekeepedPlugins[0].name).toEqual(name);
+});
+
+test('requirePlugin returns null for invalid requires', async () => {
+  const requireFn = createRequirePluginFunction(() => {
+    throw new Error();
+  });
+  const plugin = await requireFn([])({
+    ...sampleInstalledPluginDetails,
+    name: 'pluginID',
+    dir: '/Users/mock/.flipper/thirdparty/flipper-plugin-sample',
+    entry: 'this/path/does not/exist',
+    version: '1.0.0',
+  });
+
+  expect(plugin).toBeNull();
+});
+
+test('newest version of each plugin is used', () => {
+  const bundledPlugins: BundledPluginDetails[] = [
+    {
+      ...sampleBundledPluginDetails,
+      id: 'TestPlugin1',
+      name: 'flipper-plugin-test1',
+      version: '0.1.0',
+    },
+    {
+      ...sampleBundledPluginDetails,
+      id: 'TestPlugin2',
+      name: 'flipper-plugin-test2',
+      version: '0.1.0-alpha.201',
+    },
+  ];
+  const installedPlugins: InstalledPluginDetails[] = [
+    {
+      ...sampleInstalledPluginDetails,
+      id: 'TestPlugin2',
+      name: 'flipper-plugin-test2',
+      version: '0.1.0-alpha.21',
+      dir: '/Users/mock/.flipper/thirdparty/flipper-plugin-test2',
+      entry: './test/index.js',
+    },
+    {
+      ...sampleInstalledPluginDetails,
+      id: 'TestPlugin1',
+      name: 'flipper-plugin-test1',
+      version: '0.10.0',
+      dir: '/Users/mock/.flipper/thirdparty/flipper-plugin-test1',
+      entry: './test/index.js',
+    },
+  ];
+  const filteredPlugins = getLatestCompatibleVersionOfEachPlugin(
+    [...bundledPlugins, ...installedPlugins],
+    '0.1.0',
+  );
+  expect(filteredPlugins).toHaveLength(2);
+  expect(filteredPlugins).toContainEqual({
+    ...sampleInstalledPluginDetails,
+    id: 'TestPlugin1',
+    name: 'flipper-plugin-test1',
+    version: '0.10.0',
+    dir: '/Users/mock/.flipper/thirdparty/flipper-plugin-test1',
+    entry: './test/index.js',
+  });
+  expect(filteredPlugins).toContainEqual({
+    ...sampleBundledPluginDetails,
+    id: 'TestPlugin2',
+    name: 'flipper-plugin-test2',
+    version: '0.1.0-alpha.201',
+  });
+});

desktop/flipper-frontend-core/src/plugins.tsx

@@ -43,6 +43,10 @@ export abstract class AbstractPluginInitializer {
     return this._initialPlugins;
   }
 
+  get requirePlugin() {
+    return createRequirePluginFunction(this.requirePluginImpl.bind(this));
+  }
+
   protected async _init(): Promise<_SandyPluginDefinition[]> {
     this.loadDefaultPluginIndex();
     this.loadMarketplacePlugins();
@@ -100,9 +104,7 @@ export abstract class AbstractPluginInitializer {
   }
 
   protected async loadPlugins(pluginsToLoad: ActivatablePluginDetails[]) {
-    const loader = createRequirePluginFunction(
-      this.requirePluginImpl.bind(this),
-    )(this.failedPlugins);
+    const loader = this.requirePlugin(this.failedPlugins);
     const initialPlugins: _SandyPluginDefinition[] = (
       await pMap(pluginsToLoad, loader)
     ).filter(notNull);
@@ -267,7 +269,7 @@ export const createRequirePluginFunction =
     };
   };
 
-const wrapRequirePlugin =
+export const wrapRequirePlugin =
   (
     requirePluginImpl: (
       pluginDetails: ActivatablePluginDetails,