From 3e336d234989c06b6b76dcc62ad678056288de4a Mon Sep 17 00:00:00 2001 From: John Knox Date: Fri, 1 Mar 2019 04:17:42 -0800 Subject: [PATCH] Print error when adb client creation fails Summary: It looks like the shell method of creating an adb client is failing almost all of the time: https://fburl.com/scuba/6ac2zhxn Thankfully we have the adbkit fallback, but we don't have the error message to see why it's failing: https://our.intern.facebook.com/intern/logview/details/infinity_javascript/dab8d34562f0cdb835132f8825317942/ Reviewed By: danielbuechele Differential Revision: D14260406 fbshipit-source-id: 6b21b5d9a4806780daa7ce692770788067364d12 --- src/utils/adbClient.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/utils/adbClient.js b/src/utils/adbClient.js index a993121e5..883127cad 100644 --- a/src/utils/adbClient.js +++ b/src/utils/adbClient.js @@ -40,7 +40,8 @@ function createClient() { 'createADBClient.shell', ).catch(err => { console.error( - 'Failed to create adb client using shell adb command. Trying with adbkit', + 'Failed to create adb client using shell adb command. Trying with adbkit.\n' + + err.toString(), ); /* In the event that starting adb with the above method fails, fallback