From 3bf9bcc2757b32412e28f42288e059447c6f073a Mon Sep 17 00:00:00 2001 From: John Knox Date: Fri, 18 Dec 2020 09:20:19 -0800 Subject: [PATCH] Reorganise the sdk installation sidebar Summary: Give the sdk installation pages a bit more structure. To me it's much clearer now what they are. Happy to hear differing opinions so we get it right :) Reviewed By: passy Differential Revision: D25638164 fbshipit-source-id: 86b7fecd8aba0068336b15a308f4a9433817c68e --- docs/getting-started/android-native.mdx | 2 +- docs/getting-started/ios-native.mdx | 2 +- docs/getting-started/react-native-android.mdx | 2 +- docs/getting-started/react-native-ios.mdx | 2 +- docs/getting-started/react-native.mdx | 2 +- website/sidebars.js | 38 +++++++++++++++---- 6 files changed, 35 insertions(+), 13 deletions(-) diff --git a/docs/getting-started/android-native.mdx b/docs/getting-started/android-native.mdx index 09bd0bc8c..153760d06 100644 --- a/docs/getting-started/android-native.mdx +++ b/docs/getting-started/android-native.mdx @@ -1,7 +1,7 @@ --- id: android-native title: Adding Flipper to Android apps with Gradle -sidebar_label: Adding Flipper to Android apps with Gradle +sidebar_label: Android with Gradle --- import useBaseUrl from '@docusaurus/useBaseUrl'; import Link from '@docusaurus/Link'; diff --git a/docs/getting-started/ios-native.mdx b/docs/getting-started/ios-native.mdx index 838dc164a..40911754b 100644 --- a/docs/getting-started/ios-native.mdx +++ b/docs/getting-started/ios-native.mdx @@ -1,7 +1,7 @@ --- id: ios-native title: Adding Flipper to iOS apps -sidebar_label: Adding Flipper to iOS apps +sidebar_label: Generic iOS apps --- import useBaseUrl from '@docusaurus/useBaseUrl'; import Link from '@docusaurus/Link'; diff --git a/docs/getting-started/react-native-android.mdx b/docs/getting-started/react-native-android.mdx index 03b5a24db..9638280c5 100644 --- a/docs/getting-started/react-native-android.mdx +++ b/docs/getting-started/react-native-android.mdx @@ -1,7 +1,7 @@ --- id: react-native-android title: Manually set up your React Native Android App -sidebar_label: React Native for Android +sidebar_label: Manual Android Setup --- import useBaseUrl from '@docusaurus/useBaseUrl'; import Link from '@docusaurus/Link'; diff --git a/docs/getting-started/react-native-ios.mdx b/docs/getting-started/react-native-ios.mdx index 63132e873..2d02e7bd4 100644 --- a/docs/getting-started/react-native-ios.mdx +++ b/docs/getting-started/react-native-ios.mdx @@ -1,7 +1,7 @@ --- id: react-native-ios title: Manually set up your React Native iOS App -sidebar_label: React Native for iOS +sidebar_label: Manual iOS Setup --- import useBaseUrl from '@docusaurus/useBaseUrl'; import Link from '@docusaurus/Link'; diff --git a/docs/getting-started/react-native.mdx b/docs/getting-started/react-native.mdx index 2e253e1a4..10dd318b2 100644 --- a/docs/getting-started/react-native.mdx +++ b/docs/getting-started/react-native.mdx @@ -1,7 +1,7 @@ --- id: react-native title: Set up your React Native App -sidebar_label: React Native +sidebar_label: Automatic Setup --- import useBaseUrl from '@docusaurus/useBaseUrl'; import Link from '@docusaurus/Link'; diff --git a/website/sidebars.js b/website/sidebars.js index 9e6b79ccb..a951b3a49 100644 --- a/website/sidebars.js +++ b/website/sidebars.js @@ -7,7 +7,7 @@ * @format */ -const {fbInternalOnly} = require('internaldocs-fb-helpers'); +const {fbInternalOnly, fbContent} = require('internaldocs-fb-helpers'); module.exports = { features: { @@ -38,13 +38,35 @@ module.exports = { setup: { 'Getting Started': [ 'getting-started/index', - ...fbInternalOnly(['fb/Add-flipper-to-android-app']), - 'getting-started/android-native', - ...fbInternalOnly(['fb/Adding-flipper-to-ios-app']), - 'getting-started/ios-native', - 'getting-started/react-native', - 'getting-started/react-native-android', - 'getting-started/react-native-ios', + { + 'Adding Flipper to your app': [ + ...fbContent({ + external: [ + 'getting-started/android-native', + 'getting-started/ios-native', + ], + internal: [ + { + Android: [ + 'fb/Add-flipper-to-android-app', + 'getting-started/android-native', + ], + iOS: [ + 'fb/Adding-flipper-to-ios-app', + 'getting-started/ios-native', + ], + }, + ], + }), + { + 'React Native': [ + 'getting-started/react-native', + 'getting-started/react-native-android', + 'getting-started/react-native-ios', + ], + }, + ], + }, 'troubleshooting', { 'Other Platforms': [