From 3a6d7517a45a5437324a168b3f2b64af0d3b134d Mon Sep 17 00:00:00 2001 From: Michel Weststrate Date: Wed, 24 Feb 2021 07:54:17 -0800 Subject: [PATCH] Fix a crash if a device disconnected while a Sheet was open Summary: A temporarily hack that was a left-over from the past where we could switch between Sandy and non-Sandy UI, caused Flipper to crash. This is the first runtime crash we find with the new Crash reporting dialog last week :) Changelog: Fixed an issue where Flipper could occasionally crash when disconnecting a device Reviewed By: passy Differential Revision: D26634620 fbshipit-source-id: 5ca0b14dee332859a4d8af27501f0916c55a1370 --- desktop/app/src/chrome/Sheet.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/desktop/app/src/chrome/Sheet.tsx b/desktop/app/src/chrome/Sheet.tsx index 5f4f1d35a..758246c1c 100644 --- a/desktop/app/src/chrome/Sheet.tsx +++ b/desktop/app/src/chrome/Sheet.tsx @@ -76,8 +76,6 @@ class Sheet extends Component { } componentWillUnmount() { - // When switching to Sandy, we need to short-circuit this as this component itself will be thrown away - this.props.onHideSheet(); document.removeEventListener('keydown', this.onKeyDown); }