From 39841292d148c412438fd1eeab1aa564378e4d9b Mon Sep 17 00:00:00 2001 From: Andrey Goncharov Date: Mon, 29 Nov 2021 04:22:20 -0800 Subject: [PATCH] Add legacy connection warning Summary: Add legacy connection warning Reviewed By: passy Differential Revision: D32694056 fbshipit-source-id: e6d1c2fb5aea607d090ab45879c5a46d5fd17dab --- .../flipper-server-core/src/comms/BrowserServerWebSocket.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/desktop/flipper-server-core/src/comms/BrowserServerWebSocket.tsx b/desktop/flipper-server-core/src/comms/BrowserServerWebSocket.tsx index 3a4d345a1..69bcd417c 100644 --- a/desktop/flipper-server-core/src/comms/BrowserServerWebSocket.tsx +++ b/desktop/flipper-server-core/src/comms/BrowserServerWebSocket.tsx @@ -79,7 +79,10 @@ class BrowserServerWebSocket extends SecureServerWebSocket { // Remove this part once our current customers migrate to the new message structure if (isLegacyMessage(parsedMessage)) { if (parsedMessage.type === 'connect') { - // TODO: Show a user warning about legacy message structure and protocol. Provide them with clear instructions on how to upgrade. + // TODO: Add a link to a blog post when it is ready. + console.warn( + '[conn] Legacy WebSocket connection. Please, upgrade. See https://github.com/facebook/flipper/tree/main/js/js-flipper for references.', + ); // Legacy protocol supported passing an optional list of plugins with a 'connect' message. // Clients that pass the list of plugins this way might not suport `getPlugins` call.