Remove dynamic data from error
Summary: Dynamic information means we can't deduplicate on the backend. Logging the serial as a warning instead. In general, I'm not convinced this is a good error to begin with as it seems expected that devices can disappear on disconnect but getting a better count should help to make that decision. Reviewed By: aigoncharov Differential Revision: D34247723 fbshipit-source-id: ace3c32d2370433dcca2debbea3a2c5d7a2ecb57
This commit is contained in:
committed by
Facebook GitHub Bot
parent
277e18133b
commit
3945675ca0
@@ -473,7 +473,8 @@ export class FlipperServerImpl implements FlipperServer {
|
|||||||
getDevice(serial: string): ServerDevice {
|
getDevice(serial: string): ServerDevice {
|
||||||
const device = this.devices.get(serial);
|
const device = this.devices.get(serial);
|
||||||
if (!device) {
|
if (!device) {
|
||||||
throw new Error('No device with serial: ' + serial);
|
console.warn(`No device with serial ${serial}.`);
|
||||||
|
throw new Error('No device with matching serial.');
|
||||||
}
|
}
|
||||||
return device;
|
return device;
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user