jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Factor out realDevice [7/n]

Browse Source 
Summary: `device.realDevice` was the escape hatch used in Sandy plugins to give access to device specific features like taking screenshots, clearing logs or accessing `adb`. Since in decapitated Flipper that won't be possible anymore (since plugins run in the client but device implementations on the server), all escape hatches have been bridged in this stack, and we can get of the `realDevice` interaction, by explicitly exposing those cases, which makes it type safe as well.

Reviewed By: passy

Differential Revision: D31079509

fbshipit-source-id: c9ec2e044d0dec0ccb1de287cf424907b198f818
This commit is contained in:
Michel Weststrate
2021-09-22 09:01:29 -07:00
committed by Facebook GitHub Bot
parent 11a27f9e1a
commit 3882357579
23 changed files with 106 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
desktop/plugins/public/logs/index.tsx
View File

@@ -156,7 +156,7 @@ export function devicePlugin(client: DevicePluginClient) {
if (isPaused.get() && client.device.isConnected) {
// start listening to the logs
isPaused.set(false);
logDisposer = client.device.onLogEntry((entry: DeviceLogEntry) => {
logDisposer = client.onDeviceLogEntry((entry: DeviceLogEntry) => {
const lastIndex = rows.size - 1;
const previousRow = rows.get(lastIndex);
if (
@@ -182,9 +182,8 @@ export function devicePlugin(client: DevicePluginClient) {
}
}
function clearLogs() {
// Non public Android specific api
(client.device.realDevice as any)?.clearLogs?.();
async function clearLogs() {
await client.device.clearLogs();
rows.clear();
tableManagerRef.current?.clearSelection();
}