Allow steps to fail with error message

Summary:
Add a method to add error messages into failed steps. This will be surfaced in the diagnostic screen, to help the user
troubleshoot.

Reviewed By: passy

Differential Revision: D9333322

fbshipit-source-id: 5f1e55c3d71b19292dbc428aaecfbd41e7a75125

xplat/Sonar/SonarWebSocketImpl.cpp

@@ -123,19 +123,23 @@ void SonarWebSocketImpl::startSync() {
       doCertificateExchange();
       return;
     }
-    connectSecurely();
 
+    connectSecurely();
     connect->complete();
   } catch (const folly::AsyncSocketException& e) {
     if (e.getType() == folly::AsyncSocketException::NOT_OPEN) {
       // The expected code path when flipper desktop is not running.
+      // Don't count as a failed attempt.
+      connect->fail("Port not open");
     } else {
       SONAR_LOG(e.what());
       failedConnectionAttempts_++;
+      connect->fail(e.what());
     }
     reconnect();
   } catch (const std::exception& e) {
     SONAR_LOG(e.what());
+    connect->fail(e.what());
     failedConnectionAttempts_++;
     reconnect();
   }