jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Logger issue in OSS build (#102)

Browse Source 
Summary:
We've replaced the global console.* methods with those in the Logger.
The OSS Logger uses a different implementation to the internal fb one, and it still calls back to console.*, causing a stack overflow.
Fix it by removing the console calls from Logger.js.
Logging to the original console methods is done by the Proxy in App.js.

Fixes #101
Closes https://github.com/facebook/Sonar/pull/102

Reviewed By: priteshrnandgaonkar

Differential Revision: D8617042

Pulled By: jknoxville

fbshipit-source-id: 055bf0e1a2fba8ad5312c88fa97a44389eb52390
This commit is contained in:
John Knox
2018-06-25 13:51:01 -07:00
committed by Facebook Github Bot
parent 64a61a37d4
commit 361a4cca76
1 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/fb-stubs/Logger.js
View File

@@ -20,21 +20,11 @@ export default class LogManager {
trackTimeSince(mark: string, eventName: ?string) {} trackTimeSince(mark: string, eventName: ?string) {}
info(data: any, category: string) { info(data: any, category: string) {}
// eslint-disable-next-line
console.info(data, category);
}
warn(data: any, category: string) { warn(data: any, category: string) {}
console.warn(data, category);
}
error(data: any, category: string) { error(data: any, category: string) {}
console.error(data, category);
}
debug(data: any, category: string) { debug(data: any, category: string) {}
// eslint-disable-next-line
console.debug(data, category);
}
} }