jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Analytics: log both shown and suppressed warnings

Browse Source 
Summary: A small enhancement for the Doctor usage report

Reviewed By: passy

Differential Revision: D19496887

fbshipit-source-id: 1f0efb0eb29e2efce60ba4fca3bd6fdc062406ea
This commit is contained in:
Anton Nikolaev
2020-01-21 06:40:31 -08:00
committed by Facebook Github Bot
parent 94e2230583
commit 35d62e70cb
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/chrome/DoctorBar.tsx
View File

@@ -55,14 +55,17 @@ class DoctorBar extends Component<Props, State> {
async showMessageIfChecksFailed() { async showMessageIfChecksFailed() {
await runHealthchecks(this.props); await runHealthchecks(this.props);
if ( if (
(this.props.healthcheckResult.status === 'FAILED' || this.props.healthcheckResult.status === 'FAILED' ||
this.props.healthcheckResult.status === 'WARNING') && this.props.healthcheckResult.status === 'WARNING'
!this.props.healthcheckResult.isAcknowledged
) { ) {
if (this.props.healthcheckResult.isAcknowledged) {
reportUsage('doctor:warning:suppressed');
} else {
this.setVisible(true); this.setVisible(true);
reportUsage('doctor:warning:shown'); reportUsage('doctor:warning:shown');
} }
} }
}
render() { render() {
return ( return (
this.state.visible && ( this.state.visible && (