jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

automatically select reconnected clients

Browse Source 
Summary:
Changelog: Flipper will no automatically select any newly connected client

This reverts D26250896 (2df117923c) to V5, which is to aggressively select new clients. The current behavior was too conservative and caused Flipper to jump to a different client, without returning, after reconnecting a disconnected device.

As reported in https://fb.workplace.com/groups/flippersupport/permalink/1084676302013027/

Reviewed By: fabiomassimo

Differential Revision: D26691046

fbshipit-source-id: b16af2052f58dc1d4254eb1e6ebbb5848c53ed7e
This commit is contained in:
Michel Weststrate
2021-02-26 07:24:40 -08:00
committed by Facebook GitHub Bot
parent f2689d3a5d
commit 357d2991d5
1 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
desktop/app/src/dispatcher/server.tsx
View File

@@ -122,18 +122,7 @@ export function registerNewClient(store: Store, client: Client) {
const device = client.deviceSync;
if (device) {
const selectedDevice = connections.selectedDevice;
const selectedClient = connections.clients.find(
(c) => c.id === connections.selectedApp,
);
if (
// If this condition meets, it means that the previous app wasn't selected explicitly by the user
connections.selectedApp !== connections.userPreferredApp ||
!selectedClient ||
!selectedDevice
) {
store.dispatch(selectDevice(device));
store.dispatch(selectClient(client.id));
}
store.dispatch(selectDevice(device));
store.dispatch(selectClient(client.id));
}
}