Restore device icons [3/n]

Summary: Restored support for device icons which was disabled in previous diff

Reviewed By: passy

Differential Revision: D31054802

fbshipit-source-id: 107a53f06159211534cb9a2316340af7a7ca530a

desktop/app/src/devices/ArchivedDevice.tsx

@@ -44,9 +44,9 @@ export default class ArchivedDevice extends BaseDevice {
         title: options.title,
         os: options.os,
         serial: options.serial,
+        icon: 'box',
       },
     );
-    this.icon = 'box';
     this.connected.set(false);
     this.source = options.source || '';
     this.supportRequestDetails = options.supportRequestDetails;

desktop/app/src/devices/BaseDevice.tsx

@@ -79,7 +79,9 @@ export default class BaseDevice {
   }
 
   // possible src of icon to display next to the device title
-  icon: string | null | undefined;
+  get icon() {
+    return this.description.icon;
+  }
 
   logListeners: Map<Symbol, DeviceLogListener> = new Map();