From 33ae7f23dbd616e0a3c0bfe5d64775563e9c9cb2 Mon Sep 17 00:00:00 2001 From: Andrey Goncharov Date: Thu, 11 May 2023 08:14:05 -0700 Subject: [PATCH] Fix column sorting not visible Summary: Fixes a regression from D45394048. It "sortable" as a nullable column prop. When it is undefined it should be treated as true. Reviewed By: LukeDefeo Differential Revision: D45776216 fbshipit-source-id: dcd8ce97217086deab7b2b1852837fbfa7437d13 --- desktop/flipper-plugin/src/ui/data-table/TableHead.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/desktop/flipper-plugin/src/ui/data-table/TableHead.tsx b/desktop/flipper-plugin/src/ui/data-table/TableHead.tsx index fc0dd9085..75a5dee41 100644 --- a/desktop/flipper-plugin/src/ui/data-table/TableHead.tsx +++ b/desktop/flipper-plugin/src/ui/data-table/TableHead.tsx @@ -175,7 +175,7 @@ function TableHeadColumn({ }; let divProps: HTMLAttributes = {}; - if (column.sortable) { + if (column.sortable !== false) { divProps = { onClick: (e) => { e.stopPropagation(); @@ -208,7 +208,7 @@ function TableHeadColumn({ ) : ( column.title )} - {column.sortable ? ( + {column.sortable !== false ? (