Fix bug where if events come in the creation of a new tab throws exception
Summary: See title. The issue occurs because this tabs component derives a key by essentially serializing the children. Since its possible for different elements in the UIDebugger to have different number of tabs, due to framework events not always being present this was never anticipated. Solution is to just let the callee supply a storage key which does not depend on the exact number of tabs Reviewed By: lblasa Differential Revision: D47520033 fbshipit-source-id: 67e57db5110fde52451d30496c25a25b0eb4a6f7
This commit is contained in:
committed by
Facebook GitHub Bot
parent
ff7182525a
commit
3282417663
@@ -55,7 +55,11 @@ export const Inspector: React.FC<Props> = ({
|
||||
|
||||
return (
|
||||
<Layout.Container gap pad>
|
||||
<Tabs grow centered key={selectedNodeId}>
|
||||
<Tabs
|
||||
localStorageKeyOverride="sidebar-tabs"
|
||||
grow
|
||||
centered
|
||||
key={selectedNodeId}>
|
||||
<Tab
|
||||
key={'identity'}
|
||||
tab={
|
||||
|
||||
Reference in New Issue
Block a user