jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix failing build by not propagating deployment target to deps (#2103)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2103

Local builds break if the deploy target of deps isn't new enough. It seems that the project podfile is not respected in this regard, as reported here: https://stackoverflow.com/a/37289688/1983583. Will see if there is a better way to fix this.

Reviewed By: jknoxville

Differential Revision: D27328025

fbshipit-source-id: 6c5ac2dc88c3dd90dd84ce691a4f8e42188f96c2
This commit is contained in:
Michel Weststrate
2021-03-25 10:02:40 -07:00
committed by Facebook GitHub Bot
parent 49d763ad5a
commit 32447c9026
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
react-native/ReactNativeFlipperExample/ios/Podfile
View File

@@ -22,5 +22,11 @@ target 'ReactNativeFlipperExample' do
use_flipper!({ 'Flipper' => '0.82.0' }) use_flipper!({ 'Flipper' => '0.82.0' })
post_install do |installer| post_install do |installer|
flipper_post_install(installer) flipper_post_install(installer)
# based on https://stackoverflow.com/a/37289688/1983583
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '10.0'
end
end
end end
end end

6
react-native/ReactNativeFlipperExample/ios/Podfile.lock
View File

@@ -472,7 +472,7 @@ EXTERNAL SOURCES:
SPEC CHECKSUMS: SPEC CHECKSUMS:
boost-for-react-native: 39c7adb57c4e60d6c5479dd8623128eb5b3f0f2c boost-for-react-native: 39c7adb57c4e60d6c5479dd8623128eb5b3f0f2c
CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99 CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
DoubleConversion: cde416483dac037923206447da6e1454df403714 DoubleConversion: cf9b38bf0b2d048436d9a82ad2abe1404f11e7de
FBLazyVector: 49cbe4b43e445b06bf29199b6ad2057649e4c8f5 FBLazyVector: 49cbe4b43e445b06bf29199b6ad2057649e4c8f5
FBReactNativeSpec: 9e9f783f0e063dba3464ba0f9a826ac6c7f2908f FBReactNativeSpec: 9e9f783f0e063dba3464ba0f9a826ac6c7f2908f
Flipper: b6ab74c50d17c375c0ed3f729489cd1030f7c511 Flipper: b6ab74c50d17c375c0ed3f729489cd1030f7c511
@@ -482,7 +482,7 @@ SPEC CHECKSUMS:
Flipper-PeerTalk: 116d8f857dc6ef55c7a5a75ea3ceaafe878aadc9 Flipper-PeerTalk: 116d8f857dc6ef55c7a5a75ea3ceaafe878aadc9
Flipper-RSocket: 602921fee03edacf18f5d6f3d3594ba477f456e5 Flipper-RSocket: 602921fee03edacf18f5d6f3d3594ba477f456e5
FlipperKit: 6a68648b412158059f9021b5e61c36bb3086ebc3 FlipperKit: 6a68648b412158059f9021b5e61c36bb3086ebc3
glog: 40a13f7840415b9a77023fbcae0f1e6f43192af3 glog: 73c2498ac6884b13ede40eda8228cb1eee9d9d62
hermes-engine: 7d97ba46a1e29bacf3e3c61ecb2804a5ddd02d4f hermes-engine: 7d97ba46a1e29bacf3e3c61ecb2804a5ddd02d4f
libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913 libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
OpenSSL-Universal: 1aa4f6a6ee7256b83db99ec1ccdaa80d10f9af9b OpenSSL-Universal: 1aa4f6a6ee7256b83db99ec1ccdaa80d10f9af9b
@@ -513,6 +513,6 @@ SPEC CHECKSUMS:
Yoga: 8c8436d4171c87504c648ae23b1d81242bdf3bbf Yoga: 8c8436d4171c87504c648ae23b1d81242bdf3bbf
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a YogaKit: f782866e155069a2cca2517aafea43200b01fd5a
PODFILE CHECKSUM: e18a5a9e62a6a77042fc43d0d959332ffc5f68ae PODFILE CHECKSUM: e0e627b0d2a4b1e3329fac7c2c46a79fa1e7aac8
COCOAPODS: 1.10.1 COCOAPODS: 1.10.1