jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove checkbox as boolean value

Browse Source 
Summary:
Remove checkbox as we currently don't support editing values.

Instead replace with a simple 'TRUE', 'FALSE' text.

Reviewed By: antonk52

Differential Revision: D41532898

fbshipit-source-id: d4af37e30eb21ab761c39cb4ae45337247c80c9d
This commit is contained in:
Lorenzo Blasa
2022-11-25 08:14:08 -08:00
committed by Facebook GitHub Bot
parent ea0af7c931
commit 3044ddc5c1
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
desktop/plugins/public/ui-debugger/components/sidebar/inspector/AttributesInspector.tsx
View File

@@ -16,7 +16,7 @@ import {
UINode, UINode,
} from '../../../types'; } from '../../../types';
import {DataInspector, Panel, styled} from 'flipper-plugin'; import {DataInspector, Panel, styled} from 'flipper-plugin';
import {Checkbox, Col, Row} from 'antd'; import {Col, Row} from 'antd';
import {displayableName} from '../utilities/displayableName'; import {displayableName} from '../utilities/displayableName';
import ColorInspector from './ColorInspector'; import ColorInspector from './ColorInspector';
import SizeInspector from './SizeInspector'; import SizeInspector from './SizeInspector';
@@ -26,6 +26,7 @@ import Coordinate3DInspector from './Coordinate3DInspector';
import CoordinateInspector from './CoordinateInspector'; import CoordinateInspector from './CoordinateInspector';
import { import {
AutoMarginStyle, AutoMarginStyle,
BooleanAttributeValueStyle,
EnumAttributeValueStyle, EnumAttributeValueStyle,
NumberAttributeValueStyle, NumberAttributeValueStyle,
ObjectContainerStyle, ObjectContainerStyle,
@@ -36,6 +37,7 @@ import {Glyph} from 'flipper';
import {transform} from '../../../dataTransform'; import {transform} from '../../../dataTransform';
const NumberValue = styled.span(NumberAttributeValueStyle); const NumberValue = styled.span(NumberAttributeValueStyle);
const BooleanValue = styled.span(BooleanAttributeValueStyle);
const TextValue = styled.span(TextAttributeValueStyle); const TextValue = styled.span(TextAttributeValueStyle);
const EnumValue = styled.span(EnumAttributeValueStyle); const EnumValue = styled.span(EnumAttributeValueStyle);
const ObjectContainer = styled.div(ObjectContainerStyle); const ObjectContainer = styled.div(ObjectContainerStyle);
@@ -98,7 +100,7 @@ function create(
case 'boolean': case 'boolean':
return ( return (
<NamedAttributeInspector name={displayableName(name)}> <NamedAttributeInspector name={displayableName(name)}>
<Checkbox checked={inspectable.value} disabled /> <BooleanValue>{inspectable.value ? 'TRUE' : 'FALSE'}</BooleanValue>
</NamedAttributeInspector> </NamedAttributeInspector>
); );
case 'enum': case 'enum':

6
desktop/plugins/public/ui-debugger/components/sidebar/inspector/Styles.tsx
View File

@@ -55,6 +55,12 @@ export const NumberAttributeValueStyle = {
display: 'flex', display: 'flex',
} as const; } as const;
export const BooleanAttributeValueStyle = {
color: theme.semanticColors.booleanValue,
fontSize: theme.fontSize.small,
alignItems: 'center',
} as const;
export const TextAttributeValueStyle = { export const TextAttributeValueStyle = {
color: theme.semanticColors.stringValue, color: theme.semanticColors.stringValue,
display: 'flex', display: 'flex',