jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify data table power search config for each column

Browse Source 
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49410973

fbshipit-source-id: d8854eefaf1901c4984300df955a15c77c03505e
This commit is contained in:
Andrey Goncharov
2023-09-19 08:19:25 -07:00
committed by Facebook GitHub Bot
parent 3b75b6994b
commit 3022b8ddb1
2 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/flipper-plugin/src/index.tsx
View File

@@ -61,7 +61,7 @@ export {DataTable, DataTableColumn} from './ui/data-table/DataTable';
export {DataTableManager} from './ui/data-table/DataTableManager'; export {DataTableManager} from './ui/data-table/DataTableManager';
export { export {
DataTable as _DataTableWithPowerSearch, DataTable as _DataTableWithPowerSearch,
DataTableColumn as _DataColumnWithPowerSearch, DataTableColumn as _DataTableColumnWithPowerSearch,
} from './ui/data-table/DataTableWithPowerSearch'; } from './ui/data-table/DataTableWithPowerSearch';
export {DataTableManager as _DataTableWithPowerSearchManager} from './ui/data-table/DataTableWithPowerSearchManager'; export {DataTableManager as _DataTableWithPowerSearchManager} from './ui/data-table/DataTableWithPowerSearchManager';
export {DataList} from './ui/DataList'; export {DataList} from './ui/DataList';

20
desktop/flipper-plugin/src/ui/data-table/DataTableWithPowerSearch.tsx
View File

@@ -61,7 +61,12 @@ import {
_DataSourceView, _DataSourceView,
} from 'flipper-plugin-core'; } from 'flipper-plugin-core';
import {useLatestRef} from '../../utils/useLatestRef'; import {useLatestRef} from '../../utils/useLatestRef';
import {PowerSearch, PowerSearchConfig, FieldConfig} from '../PowerSearch'; import {
PowerSearch,
PowerSearchConfig,
FieldConfig,
OperatorConfig,
} from '../PowerSearch';
import { import {
dataTablePowerSearchOperatorProcessorConfig, dataTablePowerSearchOperatorProcessorConfig,
dataTablePowerSearchOperators, dataTablePowerSearchOperators,
@@ -124,13 +129,7 @@ export type DataTableColumn<T = any> = {
visible?: boolean; visible?: boolean;
inversed?: boolean; inversed?: boolean;
sortable?: boolean; sortable?: boolean;
powerSearchConfig?: powerSearchConfig?: OperatorConfig[] | false;
| {
[K in keyof typeof dataTablePowerSearchOperators]: ReturnType<
(typeof dataTablePowerSearchOperators)[K]
>;
}
| false;
}; };
export interface TableRowRenderContext<T = any> { export interface TableRowRenderContext<T = any> {
@@ -249,7 +248,10 @@ export function DataTable<T extends object>(
label: column.title ?? column.key, label: column.title ?? column.key,
key: column.key, key: column.key,
// If no power search config provided we treat every input as a string // If no power search config provided we treat every input as a string
operators: column.powerSearchConfig ?? { operators: column.powerSearchConfig?.reduce((res, operatorConfig) => {
res[operatorConfig.key] = operatorConfig;
return res;
}, {} as Record<string, OperatorConfig>) ?? {
string_contains: dataTablePowerSearchOperators.string_contains(), string_contains: dataTablePowerSearchOperators.string_contains(),
string_not_contains: string_not_contains:
dataTablePowerSearchOperators.string_not_contains(), dataTablePowerSearchOperators.string_not_contains(),