jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove Electron devtools closing

Browse Source 
Summary: Follow up on D31992230 (2e7015388c) to replace `require('electron')` with `global.electronRequire('electron')`. However, during testing noticed that the Hermes debugger works just fine even with Electron DevTools open, so removed the logic altogether.

Reviewed By: aigoncharov

Differential Revision: D32167673

fbshipit-source-id: c6c6c07f07ac8c44e0f6959d56bf4c16725c186e
This commit is contained in:
Michel Weststrate
2021-11-05 05:12:46 -07:00
committed by Facebook GitHub Bot
parent 4cf1920e36
commit 2eaccff720
1 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
desktop/plugins/public/hermesdebuggerrn/ChromeDevTools.tsx
View File

@@ -26,16 +26,6 @@ function createDevToolsNode(
return existing; return existing;
} }
// It is necessary to deactivate chrome devtools in electron
try {
const electron = require('electron');
if (electron.default) {
electron.default.remote.getCurrentWindow().webContents.toggleDevTools();
electron.default.remote.getCurrentWindow().webContents.closeDevTools();
}
} catch (e) {
console.warn('Failed to close Electron devtools: ', e);
}
const wrapper = document.createElement('div'); const wrapper = document.createElement('div');
wrapper.id = devToolsNodeId(url); wrapper.id = devToolsNodeId(url);
wrapper.style.height = '100%'; wrapper.style.height = '100%';