From 2eaccff720b7771bcb33f98a983df7c3f9414994 Mon Sep 17 00:00:00 2001 From: Michel Weststrate Date: Fri, 5 Nov 2021 05:12:46 -0700 Subject: [PATCH] Remove Electron devtools closing Summary: Follow up on D31992230 (https://github.com/facebook/flipper/commit/2e7015388c75ee88a0e7c538758bd0169b1b2322) to replace `require('electron')` with `global.electronRequire('electron')`. However, during testing noticed that the Hermes debugger works just fine even with Electron DevTools open, so removed the logic altogether. Reviewed By: aigoncharov Differential Revision: D32167673 fbshipit-source-id: c6c6c07f07ac8c44e0f6959d56bf4c16725c186e --- .../plugins/public/hermesdebuggerrn/ChromeDevTools.tsx | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/desktop/plugins/public/hermesdebuggerrn/ChromeDevTools.tsx b/desktop/plugins/public/hermesdebuggerrn/ChromeDevTools.tsx index d6859fb22..e1bd0f722 100644 --- a/desktop/plugins/public/hermesdebuggerrn/ChromeDevTools.tsx +++ b/desktop/plugins/public/hermesdebuggerrn/ChromeDevTools.tsx @@ -26,16 +26,6 @@ function createDevToolsNode( return existing; } - // It is necessary to deactivate chrome devtools in electron - try { - const electron = require('electron'); - if (electron.default) { - electron.default.remote.getCurrentWindow().webContents.toggleDevTools(); - electron.default.remote.getCurrentWindow().webContents.closeDevTools(); - } - } catch (e) { - console.warn('Failed to close Electron devtools: ', e); - } const wrapper = document.createElement('div'); wrapper.id = devToolsNodeId(url); wrapper.style.height = '100%';