Events tab

Summary:
Add a frameworks events tab. This is currently using the `TimelineDataDescription` component which may ultimately be replaced by something more sophisticated.

In the meanwhile, this does the job of chronologically displaying events with a label.

Reviewed By: mweststrate

Differential Revision: D43948891

fbshipit-source-id: 31ebf8a1d0e126856c3aa5291a1a06d7f2547233
This commit is contained in:
Lorenzo Blasa
2023-03-10 06:18:21 -08:00
committed by Facebook GitHub Bot
parent d669fd08e5
commit 2dde672045

View File

@@ -10,7 +10,16 @@
import React from 'react'; import React from 'react';
// eslint-disable-next-line rulesdir/no-restricted-imports-clone // eslint-disable-next-line rulesdir/no-restricted-imports-clone
import {Glyph} from 'flipper'; import {Glyph} from 'flipper';
import {Layout, Tab, Tabs, theme, usePlugin, useValue} from 'flipper-plugin'; import {
Layout,
Tab,
Tabs,
theme,
usePlugin,
useValue,
TimelineDataDescription,
} from 'flipper-plugin';
import {Id, Metadata, MetadataId, UINode} from '../../types'; import {Id, Metadata, MetadataId, UINode} from '../../types';
import {IdentityInspector} from './inspector/IdentityInspector'; import {IdentityInspector} from './inspector/IdentityInspector';
@@ -27,11 +36,17 @@ type Props = {
export const Inspector: React.FC<Props> = ({nodes, metadata}) => { export const Inspector: React.FC<Props> = ({nodes, metadata}) => {
const instance = usePlugin(plugin); const instance = usePlugin(plugin);
const selectedNodeId = useValue(instance.uiState.selectedNode); const selectedNodeId = useValue(instance.uiState.selectedNode);
const frameworkEvents = useValue(instance.frameworkEvents);
const selectedNode = nodes.get(selectedNodeId!!); const selectedNode = selectedNodeId ? nodes.get(selectedNodeId) : undefined;
if (!selectedNode) { if (!selectedNode) {
return <NoData message="Please select a node to view its details" />; return <NoData message="Please select a node to view its details" />;
} }
const events = selectedNodeId
? frameworkEvents?.get(selectedNodeId)
: undefined;
return ( return (
<Layout.Container gap pad> <Layout.Container gap pad>
<Tabs grow centered> <Tabs grow centered>
@@ -78,6 +93,34 @@ export const Inspector: React.FC<Props> = ({nodes, metadata}) => {
metadata={metadata} metadata={metadata}
/> />
</Tab> </Tab>
{events && (
<Tab
tab={
<Tooltip title="Events">
<Layout.Horizontal center>
<Glyph
name="weather-thunder"
size={16}
color={theme.primaryColor}
/>
</Layout.Horizontal>
</Tooltip>
}>
<TimelineDataDescription
timeline={{
time: events.map((e) => {
return {
moment: e.timestamp,
display: e.type,
color: theme.primaryColor,
key: e.timestamp.toString(),
};
}),
current: '',
}}
/>
</Tab>
)}
</Tabs> </Tabs>
</Layout.Container> </Layout.Container>
); );