jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Increase OkhttpInterceptor default body size

Browse Source 
Summary:
The default max body size for the OkHttpInterceptor that is reported to Flipper seems unreasonably small, as most images, graphql responses etc are bigger. Increased it to 1MB

Since the network plugin doesn't do any work if it is not explicitly enabled in Flipper, this should not lead to further performance regression / starvation.

Reviewed By: jknoxville

Differential Revision: D23375720

fbshipit-source-id: e901105209aec7108d61fc20295a149c5582f22d
This commit is contained in:
Michel Weststrate
2020-09-02 05:11:14 -07:00
committed by Facebook GitHub Bot
parent cd197aeaaf
commit 2d7c464f3e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
android/plugins/network/src/main/java/com/facebook/flipper/plugins/network/FlipperOkhttpInterceptor.java
View File

@@ -40,8 +40,8 @@ import okio.BufferedSource;
public class FlipperOkhttpInterceptor public class FlipperOkhttpInterceptor
implements Interceptor, BufferingFlipperPlugin.MockResponseConnectionListener { implements Interceptor, BufferingFlipperPlugin.MockResponseConnectionListener {
// By default, limit body size (request or response) reporting to 100KB to avoid OOM // By default, limit body size (request or response) reporting to 1MB to avoid OOM
private static final long DEFAULT_MAX_BODY_BYTES = 100 * 1024; private static final long DEFAULT_MAX_BODY_BYTES = 1024 * 1024;
private final long mMaxBodyBytes; private final long mMaxBodyBytes;