From 2d28ca2c378c36d76f0c98b944315306dac24518 Mon Sep 17 00:00:00 2001
From: Andrey Goncharov <aigoncharov@meta.com>
Date: Fri, 10 Nov 2023 09:08:28 -0800
Subject: [PATCH] Support enum label inferral for simplified config

Reviewed By: LukeDefeo

Differential Revision: D51199436

fbshipit-source-id: c611f0d5a21d7500447342d3e2a5e12c55e9b67d
---
 .../data-table/DataTableWithPowerSearch.tsx   | 48 ++++++++++++-------
 1 file changed, 30 insertions(+), 18 deletions(-)

diff --git a/desktop/flipper-plugin/src/ui/data-table/DataTableWithPowerSearch.tsx b/desktop/flipper-plugin/src/ui/data-table/DataTableWithPowerSearch.tsx
index 7dd62e905..d7199e5ea 100644
--- a/desktop/flipper-plugin/src/ui/data-table/DataTableWithPowerSearch.tsx
+++ b/desktop/flipper-plugin/src/ui/data-table/DataTableWithPowerSearch.tsx
@@ -146,7 +146,8 @@ type DataTableInput<T = any> =
     };
 
 type PowerSearchSimplifiedConfig =
-  | {type: 'enum'; enumLabels: EnumLabels}
+  | {type: 'enum'; enumLabels: EnumLabels; inferEnumOptionsFromData?: false}
+  | {type: 'enum'; enumLabels?: never; inferEnumOptionsFromData: true}
   | {type: 'int'}
   | {type: 'float'}
   | {type: 'string'}
@@ -175,6 +176,17 @@ const powerSearchConfigIsExtendedConfig = (
   !!powerSearchConfig &&
   Array.isArray((powerSearchConfig as PowerSearchExtendedConfig).operators);
 
+const powerSearchConfigIsSimplifiedConfig = (
+  powerSearchConfig:
+    | undefined
+    | PowerSearchSimplifiedConfig
+    | OperatorConfig[]
+    | false
+    | PowerSearchExtendedConfig,
+): powerSearchConfig is PowerSearchSimplifiedConfig =>
+  !!powerSearchConfig &&
+  typeof (powerSearchConfig as PowerSearchSimplifiedConfig).type === 'string';
+
 export type DataTableColumn<T = any> = {
   //this can be a dotted path into a nest objects. e.g foo.bar
   key: keyof T & string;
@@ -311,7 +323,9 @@ export function DataTable<T extends object>(
 
     for (const column of columns) {
       if (
-        powerSearchConfigIsExtendedConfig(column.powerSearchConfig) &&
+        (powerSearchConfigIsExtendedConfig(column.powerSearchConfig) ||
+          (powerSearchConfigIsSimplifiedConfig(column.powerSearchConfig) &&
+            column.powerSearchConfig.type === 'enum')) &&
         column.powerSearchConfig.inferEnumOptionsFromData
       ) {
         if (!secondaryIndeciesKeys.has(column.key)) {
@@ -461,24 +475,22 @@ export function DataTable<T extends object>(
             break;
           }
           case 'enum': {
+            let enumLabels: EnumLabels;
+
+            if (column.powerSearchConfig.inferEnumOptionsFromData) {
+              enumLabels = inferredPowerSearchEnumLabels[column.key] ?? {};
+            } else {
+              enumLabels = column.powerSearchConfig.enumLabels;
+            }
+
             columnPowerSearchOperators = [
-              dataTablePowerSearchOperators.enum_is(
-                column.powerSearchConfig.enumLabels,
-              ),
-              dataTablePowerSearchOperators.enum_is_not(
-                column.powerSearchConfig.enumLabels,
-              ),
-              dataTablePowerSearchOperators.enum_is_nullish_or(
-                column.powerSearchConfig.enumLabels,
-              ),
-              dataTablePowerSearchOperators.enum_set_is_any_of(
-                column.powerSearchConfig.enumLabels,
-              ),
-              dataTablePowerSearchOperators.enum_set_is_none_of(
-                column.powerSearchConfig.enumLabels,
-              ),
+              dataTablePowerSearchOperators.enum_is(enumLabels),
+              dataTablePowerSearchOperators.enum_is_not(enumLabels),
+              dataTablePowerSearchOperators.enum_is_nullish_or(enumLabels),
+              dataTablePowerSearchOperators.enum_set_is_any_of(enumLabels),
+              dataTablePowerSearchOperators.enum_set_is_none_of(enumLabels),
               dataTablePowerSearchOperators.enum_set_is_nullish_or_any_of(
-                column.powerSearchConfig.enumLabels,
+                enumLabels,
               ),
             ];
             break;