improve marker timeline
Summary: 1. removed background hover 2. made can select actually work 3. disable user selection 4. remove decimal points from ms Reviewed By: lblasa Differential Revision: D48270181 fbshipit-source-id: 724efedb5cad7f93c80ed5dd7f49efe4c434c324
This commit is contained in:
committed by
Facebook GitHub Bot
parent
94114eb821
commit
2d217575bb
@@ -63,14 +63,15 @@ const Point = styled(Layout.Horizontal)<{
|
||||
right: 10,
|
||||
cursor: props.onClick ? 'pointer' : 'default',
|
||||
borderRadius: 3,
|
||||
alignItems: 'flex-start',
|
||||
alignItems: 'baseline',
|
||||
lineHeight: '16px',
|
||||
':hover': {
|
||||
backgroundColor: theme.selectionBackgroundColor,
|
||||
backgroundColor: theme.backgroundWash,
|
||||
'> span': {
|
||||
whiteSpace: 'initial',
|
||||
},
|
||||
},
|
||||
|
||||
'::before': {
|
||||
position: 'relative',
|
||||
textAlign: 'center',
|
||||
@@ -115,12 +116,15 @@ const Time = styled.span({
|
||||
});
|
||||
Time.displayName = 'MakerTimeline:Time';
|
||||
|
||||
const Code = styled(Typography.Text)({
|
||||
const Name = styled(Typography.Text)({
|
||||
overflow: 'hidden',
|
||||
opacity: 0.8,
|
||||
textOverflow: 'ellipsis',
|
||||
marginTop: -1,
|
||||
marginLeft: theme.space.tiny,
|
||||
fontFamily: 'monospace',
|
||||
});
|
||||
Code.displayName = 'MakerTimeline:Code';
|
||||
Name.displayName = 'MakerTimeline:Name';
|
||||
|
||||
type TimePoint = {
|
||||
timestamp: number;
|
||||
@@ -229,8 +233,8 @@ export class MarkerTimeline extends Component<Props, State> {
|
||||
number={
|
||||
p.markerNames.length > 1 ? p.markerNames.length : undefined
|
||||
}>
|
||||
<Time>{p.timestamp.toFixed(5)}ms</Time>{' '}
|
||||
<Code code>{p.markerNames.join(', ')}</Code>
|
||||
<Time>{p.timestamp.toFixed(0)}ms</Time>{' '}
|
||||
<Name>{p.markerNames.join(', ')}</Name>
|
||||
</Point>
|
||||
);
|
||||
})}
|
||||
|
||||
@@ -69,7 +69,7 @@ export class TimelineDataDescription extends Component<Props, State> {
|
||||
</Button>
|
||||
</div>
|
||||
)}
|
||||
<div>
|
||||
<div style={{userSelect: 'none'}}>
|
||||
<MarkerTimeline
|
||||
points={points}
|
||||
onClick={(ids) => {
|
||||
|
||||
Reference in New Issue
Block a user