jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add Flipper support for secondary processes in Messenger VR

Browse Source 
Summary: Allow callers to pass id, deviceName, processName, and packageName when initializing Flipper. Since these are used to create the connection id, callers can use these to configure Flipper to work for secondary processes.

Reviewed By: passy

Differential Revision: D44566060

fbshipit-source-id: 605264c230956f4c9643c95c610ec40d736547ac
This commit is contained in:
Razvan Racasanu
2023-04-04 11:25:23 -07:00
committed by Facebook GitHub Bot
parent a9b17ac637
commit 2c12166b54
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
android/src/main/java/com/facebook/flipper/android/AndroidFlipperClient.java
View File

@@ -26,7 +26,8 @@ public final class AndroidFlipperClient {
private static final String[] REQUIRED_PERMISSIONS = private static final String[] REQUIRED_PERMISSIONS =
new String[] {"android.permission.INTERNET", "android.permission.ACCESS_WIFI_STATE"}; new String[] {"android.permission.INTERNET", "android.permission.ACCESS_WIFI_STATE"};
public static synchronized FlipperClient getInstance(Context context) { public static synchronized FlipperClient getInstance(
Context context, String id, String deviceName, String processName, String packageName) {
if (!sIsInitialized) { if (!sIsInitialized) {
if (!(BuildConfig.IS_INTERNAL_BUILD || BuildConfig.LOAD_FLIPPER_EXPLICIT)) { if (!(BuildConfig.IS_INTERNAL_BUILD || BuildConfig.LOAD_FLIPPER_EXPLICIT)) {
Log.e("Flipper", "Attempted to initialize in non-internal build"); Log.e("Flipper", "Attempted to initialize in non-internal build");
@@ -58,16 +59,23 @@ public final class AndroidFlipperClient {
FlipperProps.getAltSecurePort(), FlipperProps.getAltSecurePort(),
getServerHost(app), getServerHost(app),
"Android", "Android",
getFriendlyDeviceName(), deviceName,
getId(), id,
getRunningAppName(app), processName,
getPackageName(app), packageName,
privateAppDirectory); privateAppDirectory);
sIsInitialized = true; sIsInitialized = true;
} }
return FlipperClientImpl.getInstance(); return FlipperClientImpl.getInstance();
} }
public static synchronized FlipperClient getInstance(Context context) {
final Context app =
context.getApplicationContext() == null ? context : context.getApplicationContext();
return getInstance(
context, getId(), getFriendlyDeviceName(), getRunningAppName(app), getPackageName(app));
}
@Nullable @Nullable
public static synchronized FlipperClient getInstanceIfInitialized() { public static synchronized FlipperClient getInstanceIfInitialized() {
if (!sIsInitialized) { if (!sIsInitialized) {