From 2b98f05d038cbfab2b52bdce1025866b295672a5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20B=C3=BCchele?= <danielbuechele@fb.com>
Date: Fri, 10 Aug 2018 09:00:18 -0700
Subject: [PATCH] add tracking for dropped frames

Summary: Adding dropped frames counter to usage events. This will allow us to track performance improvements.

Reviewed By: passy

Differential Revision: D9238608

fbshipit-source-id: d9adbb0ed72aaf13802f5eef39606970b64c8e36
---
 src/dispatcher/tracking.js | 46 ++++++++++++++++++++++++++++----------
 1 file changed, 34 insertions(+), 12 deletions(-)

diff --git a/src/dispatcher/tracking.js b/src/dispatcher/tracking.js
index a15ab9ffd..a7bb4ac13 100644
--- a/src/dispatcher/tracking.js
+++ b/src/dispatcher/tracking.js
@@ -11,29 +11,51 @@ import type {Store} from '../reducers/index.js';
 import type Logger from '../fb-stubs/Logger.js';
 
 export default (store: Store, logger: Logger) => {
+  let droppedFrames: number = 0;
+  function droppedFrameDetection(
+    past: DOMHighResTimeStamp,
+    isWindowFocused: () => boolean,
+  ) {
+    const now = performance.now();
+    requestAnimationFrame(() => droppedFrameDetection(now, isWindowFocused));
+    if (isWindowFocused()) {
+      droppedFrames += Math.max(0, Math.round(now - past / (1000 / 60) - 1));
+    }
+  }
+
+  droppedFrameDetection(
+    performance.now(),
+    () => store.getState().application.windowIsFocused,
+  );
+
   ipcRenderer.on('trackUsage', () => {
     const {
       selectedDevice,
       selectedPlugin,
       selectedApp,
+      clients,
     } = store.getState().connections;
 
     if (!selectedDevice || !selectedPlugin) {
       return;
     }
+    const info = {
+      droppedFrames,
+      os: selectedDevice.os,
+      device: selectedDevice.title,
+      plugin: selectedPlugin,
+    };
+    // reset dropped frames counter
+    droppedFrames = 0;
+
     if (selectedApp) {
-      logger.track('usage', 'ping', {
-        app: selectedApp,
-        device: selectedDevice,
-        os: selectedDevice.os,
-        plugin: selectedPlugin,
-      });
-    } else {
-      logger.track('usage', 'ping', {
-        os: selectedDevice.os,
-        plugin: selectedPlugin,
-        device: selectedDevice.title,
-      });
+      const client = clients.find((c: Client) => c.id === selectedApp);
+      if (client) {
+        // $FlowFixMe
+        info.app = client.query.app;
+      }
     }
+
+    logger.track('usage', 'ping', info);
   });
 };