metro upgrade

Summary: Upgrading to metro@0.45.3 and adapting to API changes made by metro.

Reviewed By: passy

Differential Revision: D9940734

fbshipit-source-id: 34b07cc70c9654d9e07755816aba703a826dcae9

scripts/build-release.js

@@ -9,7 +9,7 @@ const tmp = require('tmp');
 const fs = require('fs-extra');
 const builder = require('electron-builder');
 const Platform = builder.Platform;
-const metro = require('../static/node_modules/metro');
+const Metro = require('../static/node_modules/metro');
 const compilePlugins = require('../static/compilePlugins');
 
 function generateManifest(versionNumber) {
@@ -134,19 +134,32 @@ function compile(buildFolder) {
     'Building main bundle',
     path.join(__dirname, '..', 'src', 'init.js'),
   );
-  return metro
-    .runBuild({
-      config: {
-        getProjectRoots: () => [path.join(__dirname, '..')],
-        getTransformModulePath: () =>
-          path.join(__dirname, '..', 'static', 'transforms', 'index.js'),
+  const projectRoots = path.join(__dirname, '..');
+  return Metro.runBuild(
+    {
+      reporter: {update: () => {}},
+      projectRoot: projectRoots,
+      watchFolders: [projectRoots],
+      serializer: {},
+      transformer: {
+        babelTransformerPath: path.join(
+          __dirname,
+          '..',
+          'static',
+          'transforms',
+          'index.js',
+        ),
       },
-      resetCache: true,
+    },
+    {
       dev: false,
+      minify: false,
+      resetCache: true,
+      sourceMap: true,
       entry: path.join(__dirname, '..', 'src', 'init.js'),
       out: path.join(buildFolder, 'bundle.js'),
-    })
-    .catch(die);
+    },
+  ).catch(die);
 }
 
 function copyStaticFolder(buildFolder) {

scripts/start-dev-server.js

@@ -14,7 +14,7 @@ const Convert = require('ansi-to-html');
 const chalk = require('chalk');
 const http = require('http');
 const path = require('path');
-const metro = require('../static/node_modules/metro');
+const Metro = require('../static/node_modules/metro');
 const fs = require('fs');
 
 const convertAnsi = new Convert();
@@ -48,15 +48,23 @@ function launchElectron({bundleURL, electronURL}) {
   });
 }
 
-function startMetroServer(port) {
-  return metro.runServer({
-    port,
-    watch: true,
-    config: {
-      getProjectRoots: () => [path.join(__dirname, '..')],
-      getTransformModulePath: () =>
-        path.join(__dirname, '..', 'static', 'transforms', 'index.js'),
+function startMetroServer(app) {
+  const projectRoot = path.join(__dirname, '..');
+  return Metro.runMetro({
+    projectRoot,
+    watchFolders: [projectRoot],
+    transformer: {
+      babelTransformerPath: path.join(
+        __dirname,
+        '..',
+        'static',
+        'transforms',
+        'index.js',
+      ),
     },
+    watch: true,
+  }).then(metroBundlerServer => {
+    app.use(metroBundlerServer.processRequest.bind(metroBundlerServer));
   });
 }
 
@@ -88,7 +96,7 @@ function startAssetServer(port) {
   const server = http.createServer(app);
 
   return new Promise((resolve, reject) => {
-    server.listen(port, () => resolve(server));
+    server.listen(port, () => resolve({app, server}));
   });
 }
 
@@ -162,14 +170,13 @@ function outputScreen(socket) {
 }
 
 (async () => {
-  const assetServerPort = await detect(DEFAULT_PORT);
-  const assetServer = await startAssetServer(assetServerPort);
-  const socket = addWebsocket(assetServer);
-  const metroServerPort = await detect(DEFAULT_PORT + 1);
-  await startMetroServer(metroServerPort);
+  const port = await detect(DEFAULT_PORT);
+  const {app, server} = await startAssetServer(port);
+  const socket = addWebsocket(server);
+  await startMetroServer(app);
   outputScreen(socket);
   launchElectron({
-    bundleURL: `http://localhost:${metroServerPort}/src/init.bundle`,
-    electronURL: `http://localhost:${assetServerPort}/index.dev.html`,
+    bundleURL: `http://localhost:${port}/src/init.bundle`,
+    electronURL: `http://localhost:${port}/index.dev.html`,
   });
 })();

static/compilePlugins.js

@@ -7,28 +7,26 @@
 
 const path = require('path');
 const fs = require('fs');
-const metro = require('metro');
+const Metro = require('metro');
 const util = require('util');
 const recursiveReaddir = require('recursive-readdir');
 const HOME_DIR = require('os').homedir();
 
-module.exports = (reloadCallback, pluginPaths, pluginCache) => {
+module.exports = async (reloadCallback, pluginPaths, pluginCache) => {
   const plugins = pluginEntryPoints(pluginPaths);
   if (!fs.existsSync(pluginCache)) {
     fs.mkdirSync(pluginCache);
   }
   watchChanges(plugins, reloadCallback, pluginCache);
-  return Promise.all(
-    Object.values(plugins).map(plugin =>
-      compilePlugin(plugin, false, pluginCache),
-    ),
-  )
-    .then(dynamicPlugins => {
-      // eslint-disable-next-line no-console
+  const dynamicPlugins = [];
+  for (let plugin of Object.values(plugins)) {
+    const compiledPlugin = await compilePlugin(plugin, false, pluginCache);
+    if (compiledPlugin) {
+      dynamicPlugins.push(compiledPlugin);
+    }
+  }
   console.log('✅  Compiled all plugins.');
   return dynamicPlugins;
-    })
-    .catch(console.error);
 };
 
 function watchChanges(plugins, reloadCallback, pluginCache) {
@@ -126,17 +124,6 @@ function entryPointForPluginFolder(pluginPath) {
       return acc;
     }, {});
 }
-function changeExport(path) {
-  let file = fs.readFileSync(path);
-  file = file
-    .toString()
-    .replace(
-      /\nrequire\((-?[0-9]+)\);\n*$/,
-      (_, moduleID) =>
-        `\nmodule.exports = global.require(${moduleID}).default;`,
-    );
-  fs.writeFileSync(path, file);
-}
 function mostRecentlyChanged(dir) {
   return util
     .promisify(recursiveReaddir)(dir)
@@ -146,53 +133,55 @@ function mostRecentlyChanged(dir) {
         .reduce((a, b) => (a > b ? a : b), new Date(0)),
     );
 }
-function compilePlugin(
+async function compilePlugin(
   {rootDir, name, entry, packageJSON},
   force,
   pluginCache,
 ) {
-  return new Promise((resolve, reject) => {
   const fileName = `${name}@${packageJSON.version || '0.0.0'}.js`;
   const out = path.join(pluginCache, fileName);
   const result = Object.assign({}, packageJSON, {rootDir, name, entry, out});
   // check if plugin needs to be compiled
-    mostRecentlyChanged(rootDir).then(rootDirCtime => {
-      if (
-        !force &&
-        fs.existsSync(out) &&
-        rootDirCtime < fs.lstatSync(out).ctime
-      ) {
+  const rootDirCtime = await mostRecentlyChanged(rootDir);
+  if (!force && fs.existsSync(out) && rootDirCtime < fs.lstatSync(out).ctime) {
     // eslint-disable-next-line no-console
     console.log(`🥫  Using cached version of ${name}...`);
-        resolve(result);
+    return result;
   } else {
     console.log(`⚙️  Compiling ${name}...`); // eslint-disable-line no-console
-        metro
-          .runBuild({
-            config: {
-              getProjectRoots: () => [rootDir, path.join(__dirname, '..')],
-              getTransformModulePath: () =>
-                path.join(__dirname, 'transforms', 'index.js'),
-              // a custom hash function is required, because by default metro starts
-              // numbering the modules by 1. This means all plugins would start at
-              // ID 1, which causes a clash. This is why we have a custom IDFactory.
+    try {
+      await Metro.runBuild(
+        {
+          reporter: {update: () => {}},
+          projectRoot: rootDir,
+          watchFolders: [__dirname, rootDir],
+          serializer: {
+            getRunModuleStatement: moduleID =>
+              `module.exports = global.__r(${moduleID}).default;`,
             createModuleIdFactory,
           },
-            dev: false,
-            entry,
+          transformer: {
+            babelTransformerPath: path.join(
+              __dirname,
+              'transforms',
+              'index.js',
+            ),
+          },
+        },
+        {
+          entry: entry.replace(rootDir, '.'),
           out,
-          })
-          .then(() => {
-            changeExport(out);
-            resolve(result);
-          })
-          .catch(err => {
+          dev: false,
+          sourceMap: true,
+        },
+      );
+    } catch (e) {
       console.error(
         `❌  Plugin ${name} is ignored, because it could not be compiled.`,
       );
-            console.error(err);
-          });
+      console.error(e);
+      return null;
+    }
+    return result;
   }
-    });
-  });
 }

static/package.json

@@ -12,7 +12,7 @@
     "babel-plugin-transform-object-rest-spread": "^7.0.0-beta.3",
     "babel-preset-react": "^7.0.0-beta.3",
     "babylon": "^7.0.0-beta.40",
-    "metro": "^0.28.0",
+    "metro": "^0.45.3",
     "recursive-readdir": "2.2.2"
   }
 }