jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused prop

Browse Source 
Summary:
While reading through the Inspector I found this prop passed down and not used anywhere

printer_shredder

Reviewed By: Katalune

Differential Revision: D22431895

fbshipit-source-id: 6cbc97b3faec26349a1ad900ffa455e95f53bb2b
This commit is contained in:
Paco Estevez Garcia
2020-07-08 07:00:39 -07:00
committed by Facebook GitHub Bot
parent 79997f2b38
commit 29b6be23e8
6 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
desktop/app/src/ui/components/elements-inspector/ElementsInspector.tsx
View File

@@ -61,7 +61,6 @@ export type ElementsInspectorProps = {
| ((key: ElementID | undefined | null) => any) | ((key: ElementID | undefined | null) => any)
| undefined | undefined
| null; | null;
onValueChanged: ((path: Array<string>, val: any) => any) | undefined | null;
selected: ElementID | undefined | null; selected: ElementID | undefined | null;
focused?: ElementID | undefined | null; focused?: ElementID | undefined | null;
searchResults?: ElementSearchResultSet | undefined | null; searchResults?: ElementSearchResultSet | undefined | null;

2
desktop/plugins/layout/Inspector.tsx
View File

@@ -48,7 +48,6 @@ type Props = {
selectedElement: ElementID | null | undefined; selectedElement: ElementID | null | undefined;
selectedAXElement: ElementID | null | undefined; selectedAXElement: ElementID | null | undefined;
onSelect: (ids: ElementID | null | undefined) => void; onSelect: (ids: ElementID | null | undefined) => void;
onDataValueChanged: (path: Array<string>, value: any) => void;
setPersistedState: (state: Partial<PersistedState>) => void; setPersistedState: (state: Partial<PersistedState>) => void;
persistedState: PersistedState; persistedState: PersistedState;
searchResults: ElementSearchResultSet | null; searchResults: ElementSearchResultSet | null;
@@ -443,7 +442,6 @@ export default class Inspector extends Component<Props, State> {
onElementSelected={this.onElementSelectedAtMainSection} onElementSelected={this.onElementSelectedAtMainSection}
onElementHovered={this.onElementHovered} onElementHovered={this.onElementHovered}
onElementExpanded={this.onElementExpanded} onElementExpanded={this.onElementExpanded}
onValueChanged={this.props.onDataValueChanged}
searchResults={this.props.searchResults} searchResults={this.props.searchResults}
selected={this.selected()} selected={this.selected()}
root={this.root()} root={this.root()}

1
desktop/plugins/layout/MultipleSelectionSection.tsx
View File

@@ -84,7 +84,6 @@ const MultipleSelectorSection: React.FC<MultipleSelectorSectionProps> = memo(
}} }}
onElementHovered={onElementHovered} onElementHovered={onElementHovered}
onElementExpanded={() => {}} onElementExpanded={() => {}}
onValueChanged={null}
root={null} root={null}
selected={selectedId} selected={selectedId}
elements={elements} elements={elements}

1
desktop/plugins/layout/__tests__/Inspector.node.tsx
View File

@@ -37,7 +37,6 @@ beforeEach(() => {
selectedElement={null} selectedElement={null}
selectedAXElement={null} selectedAXElement={null}
onSelect={() => {}} onSelect={() => {}}
onDataValueChanged={() => {}}
setPersistedState={() => {}} setPersistedState={() => {}}
persistedState={{ persistedState={{
rootElement: null, rootElement: null,

1
desktop/plugins/layout/index.tsx
View File

@@ -344,7 +344,6 @@ export default class LayoutPlugin extends FlipperPlugin<
selectedAXElement: this.state.selectedAXElement, selectedAXElement: this.state.selectedAXElement,
setPersistedState: this.props.setPersistedState, setPersistedState: this.props.setPersistedState,
persistedState: this.props.persistedState, persistedState: this.props.persistedState,
onDataValueChanged: this.onDataValueChanged,
searchResults: this.state.searchResults, searchResults: this.state.searchResults,
}; };

1
desktop/plugins/leak_canary/index.tsx
View File

@@ -200,7 +200,6 @@ export default class LeakCanary<PersistedState> extends FlipperPlugin<
onElementExpanded={(eid /*, deep*/) => { onElementExpanded={(eid /*, deep*/) => {
this._toggleElement(idx, eid); this._toggleElement(idx, eid);
}} }}
onValueChanged={() => {}}
selected={selected} selected={selected}
searchResults={null} searchResults={null}
root={leak.root} root={leak.root}