From 2834d3300a77fdedf3f0d2b9dca371ecfa7e815e Mon Sep 17 00:00:00 2001
From: Andrey Goncharov <aigoncharov@meta.com>
Date: Wed, 9 Aug 2023 08:01:44 -0700
Subject: [PATCH] Track filtering and searching for data table

Reviewed By: mweststrate

Differential Revision: D48116067

fbshipit-source-id: 2dee2cfd68a23e1153b3f10ff229009777e936da
---
 .../flipper-plugin/src/ui/data-table/DataTableManager.tsx    | 5 ++++-
 .../src/ui/data-table/__tests__/DataTable.node.tsx           | 3 +++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/desktop/flipper-plugin/src/ui/data-table/DataTableManager.tsx b/desktop/flipper-plugin/src/ui/data-table/DataTableManager.tsx
index 853552bce..90b5fd8fb 100644
--- a/desktop/flipper-plugin/src/ui/data-table/DataTableManager.tsx
+++ b/desktop/flipper-plugin/src/ui/data-table/DataTableManager.tsx
@@ -13,7 +13,7 @@ import {MutableRefObject, Reducer, RefObject} from 'react';
 import {DataSourceVirtualizer} from '../../data-source/index';
 import produce, {castDraft, immerable, original} from 'immer';
 import {theme} from '../theme';
-import {DataSource, _DataSourceView} from 'flipper-plugin-core';
+import {DataSource, getFlipperLib, _DataSourceView} from 'flipper-plugin-core';
 
 export type OnColumnResize = (id: string, size: number | Percentage) => void;
 export type Sorting<T = any> = {
@@ -485,6 +485,7 @@ export function createDataTableManager<T>(
       dispatch({type: 'sortColumn', column, direction});
     },
     setSearchValue(value, addToHistory = false) {
+      getFlipperLib().logger.track('usage', 'data-table:filter:search');
       dispatch({type: 'setSearchValue', value, addToHistory});
     },
     toggleSearchValue() {
@@ -506,9 +507,11 @@ export function createDataTableManager<T>(
       dispatch({type: 'setShowNumberedHistory', showNumberedHistory});
     },
     addColumnFilter(column, value, options = {}) {
+      getFlipperLib().logger.track('usage', 'data-table:filter:add-column');
       dispatch({type: 'addColumnFilter', column, value, options});
     },
     removeColumnFilter(column, label) {
+      getFlipperLib().logger.track('usage', 'data-table:filter:remove-column');
       dispatch({type: 'removeColumnFilter', column, label});
     },
     setFilterExceptions(exceptions: string[] | undefined) {
diff --git a/desktop/flipper-plugin/src/ui/data-table/__tests__/DataTable.node.tsx b/desktop/flipper-plugin/src/ui/data-table/__tests__/DataTable.node.tsx
index aff5bf374..9b7012cba 100644
--- a/desktop/flipper-plugin/src/ui/data-table/__tests__/DataTable.node.tsx
+++ b/desktop/flipper-plugin/src/ui/data-table/__tests__/DataTable.node.tsx
@@ -14,12 +14,15 @@ import {createDataSource} from 'flipper-plugin-core';
 import {computeDataTableFilter, DataTableManager} from '../DataTableManager';
 import {Button} from 'antd';
 import {sleep} from 'flipper-common';
+import {TestUtils, _setFlipperLibImplementation} from 'flipper-plugin-core';
 
 type Todo = {
   title: string;
   done: boolean;
 };
 
+_setFlipperLibImplementation(TestUtils.createMockFlipperLib());
+
 function createTestDataSource() {
   return createDataSource<Todo>([
     {