jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add Unit Test for Log Adding Logic

Browse Source 
Summary: D22047276 introduced a new way to adding log data column depending on how one sorts by time. This diff adds unit test to test the logic

Reviewed By: passy

Differential Revision: D22068114

fbshipit-source-id: 3fe01beec69d45d96f2fc2a437c3f408686565a3
This commit is contained in:
Chaiwat Ekkaewnumchai
2020-06-17 03:04:33 -07:00
committed by Facebook GitHub Bot
parent 77bc432a81
commit 2785ec2d32
1 changed files with 32 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
desktop/plugins/logs/__tests__/index.node.js → desktop/plugins/logs/__tests__/index.node.ts
View File

@@ -7,12 +7,12 @@
* @format
*/
import {addEntriesToState, processEntry} from '../index.tsx';
import {addEntriesToState, processEntry} from '../index';
import {DeviceLogEntry} from 'flipper';
const entry = {
const entry: DeviceLogEntry = {
tag: 'OpenGLRenderer',
pid: 18384,
tid: 18409,
message: 'Swap behavior 1',
date: new Date('Feb 28 2013 19:00:00 EST'),
@@ -37,17 +37,20 @@ test('addEntriesToState without current state', () => {
});
test('addEntriesToState with current state', () => {
const currentState = addEntriesToState([processEntry(entry, 'key1')]);
const processedEntry = processEntry(
const firstProcessedEntry = processEntry(entry, 'key1');
const currentState = addEntriesToState([firstProcessedEntry]);
const secondProcessedEntry = processEntry(
{
...entry,
message: 'new message',
},
'key2',
);
const newState = addEntriesToState([processedEntry], currentState);
expect(newState.rows.length).toBe(2);
const newState = addEntriesToState([secondProcessedEntry], currentState);
expect(newState.entries.length).toBe(2);
expect(newState.rows.length).toBe(2);
expect(newState.rows[0]).toEqual(firstProcessedEntry.row);
expect(newState.rows[1]).toEqual(secondProcessedEntry.row);
});
test('addEntriesToState increase counter on duplicate message', () => {
@@ -58,3 +61,25 @@ test('addEntriesToState increase counter on duplicate message', () => {
expect(newState.entries.length).toBe(2);
expect(newState.rows[0].columns.type.value.props.children).toBe(2);
});
test('addEntriesToState with reversed direction (add to front)', () => {
const firstProcessedEntry = processEntry(entry, 'key1');
const currentState = addEntriesToState([firstProcessedEntry]);
expect(currentState.rows.length).toBe(1);
expect(currentState.entries.length).toBe(1);
const secondProcessedEntry = processEntry(
{
...entry,
message: 'second message',
date: new Date('Feb 28 2013 19:01:00 EST'),
},
'key2',
);
const newState = addEntriesToState(
[secondProcessedEntry],
currentState,
'down',
);
expect(newState.entries.length).toBe(2);
expect(newState.rows.length).toBe(2);
});