Fix Flipper lints #9

Summary:
This introduces a few more lints in fact because I renamed the icon functions
to make clear that they use sync methods under the hood.

Reviewed By: timur-valiev

Differential Revision: D31964701

fbshipit-source-id: d0beb58b5b301f5428fdbfe8c65784df0d86eaad

desktop/scripts/build-release.ts

@@ -29,7 +29,11 @@ import {
   moveSourceMaps,
 } from './build-utils';
 import fetch from '@adobe/node-fetch-retry';
-import {getIcons, buildLocalIconPath, getIconURL} from '../app/src/utils/icons';
+import {
+  getIconsSync,
+  buildLocalIconPath,
+  getIconURLSync,
+} from '../app/src/utils/icons';
 import isFB from './isFB';
 import copyPackageWithDependencies from './copy-package-with-dependencies';
 import {staticDir, distDir} from './paths';
@@ -305,7 +309,7 @@ async function copyStaticFolder(buildFolder: string) {
 }
 
 function downloadIcons(buildFolder: string) {
-  const iconURLs = Object.entries(getIcons()).reduce<
+  const iconURLs = Object.entries(getIconsSync()).reduce<
     {
       name: string;
       size: number;
@@ -322,7 +326,7 @@ function downloadIcons(buildFolder: string) {
 
   return Promise.all(
     iconURLs.map(({name, size, density}) => {
-      const url = getIconURL(name, size, density);
+      const url = getIconURLSync(name, size, density);
       return fetch(url, {
         retryOptions: {
           // Be default, only 5xx are retried but we're getting the odd 404