From 2359d22b46665911cf169845fc570e808e172f46 Mon Sep 17 00:00:00 2001 From: Pritesh Nandgaonkar Date: Thu, 25 Apr 2019 10:36:18 -0700 Subject: [PATCH] Fix Analytics Summary: We were missing to log for those cases when we exported through sharable link. Also I changed logging a bit so that we can differentiate between Sharable Link and File exports Reviewed By: jknoxville Differential Revision: D15080292 fbshipit-source-id: 063e9f515e4f089ed3715e7b1ca0e66410e46541 --- src/chrome/ShareSheet.js | 16 ++++++++++++---- src/chrome/ShareSheetExportFile.js | 2 +- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/src/chrome/ShareSheet.js b/src/chrome/ShareSheet.js index 3797a9375..d7c5e90ad 100644 --- a/src/chrome/ShareSheet.js +++ b/src/chrome/ShareSheet.js @@ -18,9 +18,11 @@ import { Input, } from 'flipper'; import {shareFlipperData} from '../fb-stubs/user'; -import {exportStore} from '../utils/exportData.js'; +import {exportStore, EXPORT_FLIPPER_TRACE_EVENT} from '../utils/exportData.js'; import PropTypes from 'prop-types'; import {clipboard} from 'electron'; +import {reportPlatformFailures} from '../utils/metrics'; +export const SHARE_FLIPPER_TRACE_EVENT = 'share-flipper-link'; const Container = styled(FlexColumn)({ padding: 20, @@ -95,10 +97,16 @@ export default class ShareSheet extends Component { async componentDidMount() { try { - const {serializedString, errorArray} = await exportStore( - this.context.store, + const {serializedString, errorArray} = await reportPlatformFailures( + exportStore(this.context.store), + `${EXPORT_FLIPPER_TRACE_EVENT}:UI_LINK`, ); - const result = await shareFlipperData(serializedString); + + const result = await reportPlatformFailures( + shareFlipperData(serializedString), + `${SHARE_FLIPPER_TRACE_EVENT}`, + ); + this.setState({errorArray, result}); if (result.flipperUrl) { clipboard.writeText(String(result.flipperUrl)); diff --git a/src/chrome/ShareSheetExportFile.js b/src/chrome/ShareSheetExportFile.js index b255690c7..b4a374084 100644 --- a/src/chrome/ShareSheetExportFile.js +++ b/src/chrome/ShareSheetExportFile.js @@ -89,7 +89,7 @@ export default class ShareSheetExportFile extends Component { try { const {errorArray} = await reportPlatformFailures( exportStoreToFile(this.props.file, this.context.store), - `${EXPORT_FLIPPER_TRACE_EVENT}:UI`, + `${EXPORT_FLIPPER_TRACE_EVENT}:UI_FILE`, ); this.setState({errorArray, result: {success: true, error: null}}); } catch (err) {