Fix device cleanup

Summary:
Fixes https://github.com/facebook/flipper/issues/1989

We had some self healing side effect that would destroy devices when registering a new device with the same serial, if they weren't yet. Redux isn't too happy about that, causing the attached crash.

Instead introduced a utility to destroy devices, and log an error if the device life cycle isn't respected by the device implementations, rather than crashing we will now just waste some memory.

Changelog: Fix a crash when disconnecting metro devices

Reviewed By: passy

Differential Revision: D26749214

fbshipit-source-id: 4c185ac521d44c1337fac8a9145440123b8b784c

desktop/app/src/server.tsx

@@ -40,6 +40,7 @@ import {initSelfInpector} from './utils/self-inspection/selfInspectionUtils';
 import ClientDevice from './devices/ClientDevice';
 import BaseDevice from './devices/BaseDevice';
 import {sideEffect} from './utils/sideEffect';
+import {destroyDevice} from './reducers/connections';
 
 type ClientInfo = {
   connection: FlipperClientConnection<any, any> | null | undefined;
@@ -206,10 +207,7 @@ class Server extends EventEmitter {
         Object.values(clients).map((p) =>
           p.then((c) => this.removeConnection(c.id)),
         );
-        this.store.dispatch({
-          type: 'UNREGISTER_DEVICES',
-          payload: new Set([deviceId]),
-        });
+        destroyDevice(this.store, this.logger, deviceId);
       };
 
       ws.on('message', (rawMessage: any) => {