Fix device cleanup

Summary:
Fixes https://github.com/facebook/flipper/issues/1989

We had some self healing side effect that would destroy devices when registering a new device with the same serial, if they weren't yet. Redux isn't too happy about that, causing the attached crash.

Instead introduced a utility to destroy devices, and log an error if the device life cycle isn't respected by the device implementations, rather than crashing we will now just waste some memory.

Changelog: Fix a crash when disconnecting metro devices

Reviewed By: passy

Differential Revision: D26749214

fbshipit-source-id: 4c185ac521d44c1337fac8a9145440123b8b784c

desktop/app/src/dispatcher/iOSDevice.tsx

@@ -21,6 +21,7 @@ import IOSDevice from '../devices/IOSDevice';
 import {registerDeviceCallbackOnPlugins} from '../utils/onRegisterDevice';
 import {addErrorNotification} from '../reducers/notifications';
 import {getStaticPath} from '../utils/pathUtils';
+import {destroyDevice} from '../reducers/connections';
 
 type iOSSimulatorDevice = {
   state: 'Booted' | 'Shutdown' | 'Shutting Down';
@@ -127,6 +128,8 @@ function processDevices(
     if (currentDeviceIDs.has(udid)) {
       currentDeviceIDs.delete(udid);
     } else {
+      // clean up offline device
+      destroyDevice(store, logger, udid);
       logger.track('usage', 'register-device', {
         os: 'iOS',
         type: type,