jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Migrate ShareSheetErrorList from js to ts

Browse Source 
Summary: Migrated ShareSheetErrorList.js to ShareSheetErrorList.tsx

Reviewed By: jknoxville

Differential Revision: D16734553

fbshipit-source-id: ed608d5b171deda1caa284c27527e2f63af67ebb
This commit is contained in:
Benjamin Elo
2019-08-12 05:49:44 -07:00
committed by Facebook Github Bot
parent 3e11e8887d
commit 223cfe53d7
4 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/chrome/ShareSheet.tsx
View File

@@ -24,7 +24,7 @@ import {shareFlipperData} from '../fb-stubs/user';
import {exportStore, EXPORT_FLIPPER_TRACE_EVENT} from '../utils/exportData'; import {exportStore, EXPORT_FLIPPER_TRACE_EVENT} from '../utils/exportData';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import {clipboard} from 'electron'; import {clipboard} from 'electron';
import ShareSheetErrorList from './ShareSheetErrorList.js'; import ShareSheetErrorList from './ShareSheetErrorList';
import {reportPlatformFailures} from '../utils/metrics'; import {reportPlatformFailures} from '../utils/metrics';
import CancellableExportStatus from './CancellableExportStatus'; import CancellableExportStatus from './CancellableExportStatus';
// $FlowFixMe: Missing type defs for node built-in. // $FlowFixMe: Missing type defs for node built-in.

9
src/chrome/ShareSheetErrorList.js → src/chrome/ShareSheetErrorList.tsx
View File

@@ -5,11 +5,12 @@
* @format * @format
*/ */
import {PureComponent, FlexColumn, Text, styled} from 'flipper'; import React, {PureComponent} from 'react';
import {FlexColumn, Text, styled} from 'flipper';
type Props = {| type Props = {
errors: Array<Error>, errors: Array<Error>;
|}; };
const ErrorMessage = styled(Text)({ const ErrorMessage = styled(Text)({
display: 'block', display: 'block',

2
src/chrome/ShareSheetExportFile.js
View File

@@ -30,7 +30,7 @@ import {
EXPORT_FLIPPER_TRACE_EVENT, EXPORT_FLIPPER_TRACE_EVENT,
} from '../utils/exportData.tsx'; } from '../utils/exportData.tsx';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import ShareSheetErrorList from './ShareSheetErrorList.js'; import ShareSheetErrorList from './ShareSheetErrorList.tsx';
const Container = styled(FlexColumn)({ const Container = styled(FlexColumn)({
padding: 20, padding: 20,

2
src/chrome/__tests__/ShareSheetErrorList.node.js
View File

@@ -5,7 +5,7 @@
* @format * @format
*/ */
import {formatError} from '../ShareSheetErrorList.js'; import {formatError} from '../ShareSheetErrorList.tsx';
test('normal error is formatted', () => { test('normal error is formatted', () => {
const e = new Error('something went wrong'); const e = new Error('something went wrong');