From 223cfe53d7200c39edcf142d284af40a8ae4dbd1 Mon Sep 17 00:00:00 2001 From: Benjamin Elo Date: Mon, 12 Aug 2019 05:49:44 -0700 Subject: [PATCH] Migrate ShareSheetErrorList from js to ts Summary: Migrated ShareSheetErrorList.js to ShareSheetErrorList.tsx Reviewed By: jknoxville Differential Revision: D16734553 fbshipit-source-id: ed608d5b171deda1caa284c27527e2f63af67ebb --- src/chrome/ShareSheet.tsx | 2 +- .../{ShareSheetErrorList.js => ShareSheetErrorList.tsx} | 9 +++++---- src/chrome/ShareSheetExportFile.js | 2 +- src/chrome/__tests__/ShareSheetErrorList.node.js | 2 +- 4 files changed, 8 insertions(+), 7 deletions(-) rename src/chrome/{ShareSheetErrorList.js => ShareSheetErrorList.tsx} (91%) diff --git a/src/chrome/ShareSheet.tsx b/src/chrome/ShareSheet.tsx index af801d4d3..24cdca81f 100644 --- a/src/chrome/ShareSheet.tsx +++ b/src/chrome/ShareSheet.tsx @@ -24,7 +24,7 @@ import {shareFlipperData} from '../fb-stubs/user'; import {exportStore, EXPORT_FLIPPER_TRACE_EVENT} from '../utils/exportData'; import PropTypes from 'prop-types'; import {clipboard} from 'electron'; -import ShareSheetErrorList from './ShareSheetErrorList.js'; +import ShareSheetErrorList from './ShareSheetErrorList'; import {reportPlatformFailures} from '../utils/metrics'; import CancellableExportStatus from './CancellableExportStatus'; // $FlowFixMe: Missing type defs for node built-in. diff --git a/src/chrome/ShareSheetErrorList.js b/src/chrome/ShareSheetErrorList.tsx similarity index 91% rename from src/chrome/ShareSheetErrorList.js rename to src/chrome/ShareSheetErrorList.tsx index 2c1c39401..d290020c2 100644 --- a/src/chrome/ShareSheetErrorList.js +++ b/src/chrome/ShareSheetErrorList.tsx @@ -5,11 +5,12 @@ * @format */ -import {PureComponent, FlexColumn, Text, styled} from 'flipper'; +import React, {PureComponent} from 'react'; +import {FlexColumn, Text, styled} from 'flipper'; -type Props = {| - errors: Array, -|}; +type Props = { + errors: Array; +}; const ErrorMessage = styled(Text)({ display: 'block', diff --git a/src/chrome/ShareSheetExportFile.js b/src/chrome/ShareSheetExportFile.js index 0da21351a..2ebca60ab 100644 --- a/src/chrome/ShareSheetExportFile.js +++ b/src/chrome/ShareSheetExportFile.js @@ -30,7 +30,7 @@ import { EXPORT_FLIPPER_TRACE_EVENT, } from '../utils/exportData.tsx'; import PropTypes from 'prop-types'; -import ShareSheetErrorList from './ShareSheetErrorList.js'; +import ShareSheetErrorList from './ShareSheetErrorList.tsx'; const Container = styled(FlexColumn)({ padding: 20, diff --git a/src/chrome/__tests__/ShareSheetErrorList.node.js b/src/chrome/__tests__/ShareSheetErrorList.node.js index 1c112bd21..eeece5501 100644 --- a/src/chrome/__tests__/ShareSheetErrorList.node.js +++ b/src/chrome/__tests__/ShareSheetErrorList.node.js @@ -5,7 +5,7 @@ * @format */ -import {formatError} from '../ShareSheetErrorList.js'; +import {formatError} from '../ShareSheetErrorList.tsx'; test('normal error is formatted', () => { const e = new Error('something went wrong');