From 21dfe41fb4f24e735b83aeb6cd4ade1ea4017424 Mon Sep 17 00:00:00 2001 From: John Knox Date: Thu, 17 Jan 2019 03:40:25 -0800 Subject: [PATCH] Add sessionId to error messages Summary: Will allow us to look into bad sessions if necessary. Reviewed By: passy Differential Revision: D13695386 fbshipit-source-id: 2cfc8ec28ef4cb387ef7a5a58b02aa77a367ae81 --- src/__tests__/App.electron.js | 2 +- src/__tests__/server.electron.js | 2 +- src/dispatcher/__tests__/plugins.electron.js | 2 +- src/fb-stubs/Logger.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/__tests__/App.electron.js b/src/__tests__/App.electron.js index 5c4d6914a..dece90a78 100644 --- a/src/__tests__/App.electron.js +++ b/src/__tests__/App.electron.js @@ -17,7 +17,7 @@ import BugReporter from '../fb-stubs/BugReporter.js'; const mockStore = configureStore([])(reducers(undefined, {type: 'INIT'})); test('Empty app state matches snapshot', () => { - const logger = initLogger(); + const logger = initLogger(mockStore); const bugReporter = new BugReporter(logger, mockStore); const component = renderer.create( diff --git a/src/__tests__/server.electron.js b/src/__tests__/server.electron.js index 5c7d84170..39503df15 100644 --- a/src/__tests__/server.electron.js +++ b/src/__tests__/server.electron.js @@ -23,7 +23,7 @@ beforeAll(() => { fs.mkdirSync(flipperDir); } - const logger = initLogger(); + const logger = initLogger(mockStore); server = new Server(logger, mockStore); return server.init(); }); diff --git a/src/dispatcher/__tests__/plugins.electron.js b/src/dispatcher/__tests__/plugins.electron.js index 5fede9b61..82d30cc5e 100644 --- a/src/dispatcher/__tests__/plugins.electron.js +++ b/src/dispatcher/__tests__/plugins.electron.js @@ -21,7 +21,7 @@ import {TEST_PASSING_GK, TEST_FAILING_GK} from '../../fb-stubs/GK'; import TestPlugin from './TestPlugin'; const mockStore = configureStore([])(reducers(undefined, {type: 'INIT'})); -const logger = new Logger(); +const logger = new Logger(mockStore); test('dispatcher dispatches REGISTER_PLUGINS', () => { dispatcher(mockStore, logger); diff --git a/src/fb-stubs/Logger.js b/src/fb-stubs/Logger.js index f1b6862d1..b57deedf7 100644 --- a/src/fb-stubs/Logger.js +++ b/src/fb-stubs/Logger.js @@ -12,7 +12,7 @@ import ScribeLogger from './ScribeLogger'; var instance: ?LogManager = null; export default class LogManager { - constructor(store: ?Store) { + constructor(store: Store) { this.scribeLogger = new ScribeLogger(this); }