jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add litho accessibility rendering to Flipper accessibility mode [2/2]

Browse Source 
Summary: Completes D9667222 to allow force rendering of accessibility in litho when an accessibility service is not actually running.

Reviewed By: ikenwoo

Differential Revision: D9720987

fbshipit-source-id: 000a7413fcbe775a525ca3aca64443c3669cdf9e
This commit is contained in:
Brett Lavalla
2018-10-27 23:34:21 -07:00
committed by Facebook Github Bot
parent a2c4c98feb
commit 21c0b3ad0e
2 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
android/src/main/java/com/facebook/flipper/plugins/litho/GenerateLithoAccessibilityRenderExtensionCommand.java
View File

@@ -1,5 +1,10 @@
// Copyright 2004-present Facebook. All Rights Reserved. /*
* Copyright (c) 2004-present, Facebook, Inc.
*
* This source code is licensed under the MIT license found in the LICENSE
* file in the root directory of this source tree.
*
*/
package com.facebook.flipper.plugins.litho; package com.facebook.flipper.plugins.litho;
import android.view.View; import android.view.View;
@@ -70,8 +75,7 @@ public final class GenerateLithoAccessibilityRenderExtensionCommand
while (!lithoViewSearchStack.isEmpty()) { while (!lithoViewSearchStack.isEmpty()) {
ViewGroup v = lithoViewSearchStack.pop(); ViewGroup v = lithoViewSearchStack.pop();
if (v instanceof LithoView) { if (v instanceof LithoView) {
// TODO: uncomment once Litho open source updates ((LithoView) v).rerenderForAccessibility(forceLithoAXRender);
// ((LithoView) v).rerenderForAccessibility(forceLithoAXRender);
} else { } else {
for (int i = 0; i < v.getChildCount(); i++) { for (int i = 0; i < v.getChildCount(); i++) {
View child = v.getChildAt(i); View child = v.getChildAt(i);

15
src/plugins/layout/index.js
View File

@@ -545,14 +545,13 @@ export default class Layout extends FlipperPlugin<InspectorState> {
} }
initAX() { initAX() {
// TODO: uncomment once Litho open source updates this.client
// this.client .call('shouldShowLithoAccessibilitySettings')
// .call('shouldShowLithoAccessibilitySettings') .then((showLithoAccessibilitySettings: boolean) => {
// .then((showLithoAccessibilitySettings: boolean) => { this.setState({
// this.setState({ showLithoAccessibilitySettings,
// showLithoAccessibilitySettings, });
// }); });
// });
performance.mark('InitAXRoot'); performance.mark('InitAXRoot');
this.client.call('getAXRoot').then((element: Element) => { this.client.call('getAXRoot').then((element: Element) => {