From 21a18d3e531288fe77ab542d5260280c5ab6a0ca Mon Sep 17 00:00:00 2001 From: Hilal Alsibai Date: Tue, 6 Nov 2018 11:27:05 -0800 Subject: [PATCH] Pass real client to sidebar extension factory functions Summary: This allows sidebar extensions to have more information as to whether they should be enabled or not Reviewed By: danielbuechele Differential Revision: D12930405 fbshipit-source-id: 649d3f01da1c535f7d60b7b525b012a888ea78e0 --- src/plugins/layout/index.js | 2 ++ src/ui/components/elements-inspector/sidebar.js | 9 ++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/plugins/layout/index.js b/src/plugins/layout/index.js index 5486f735d..e215a5db8 100644 --- a/src/plugins/layout/index.js +++ b/src/plugins/layout/index.js @@ -1066,6 +1066,7 @@ export default class Layout extends FlipperPlugin { tooltips={this.getAccessibilityTooltips()} onValueChanged={this.onDataValueChanged} client={this.client} + realClient={this.realClient} logger={this.props.logger} /> ) @@ -1078,6 +1079,7 @@ export default class Layout extends FlipperPlugin { element={this.state.elements[this.state.selected]} onValueChanged={this.onDataValueChanged} client={this.client} + realClient={this.realClient} logger={this.props.logger} extensions={SidebarExtensions} /> diff --git a/src/ui/components/elements-inspector/sidebar.js b/src/ui/components/elements-inspector/sidebar.js index 41d124080..eab4a8f46 100644 --- a/src/ui/components/elements-inspector/sidebar.js +++ b/src/ui/components/elements-inspector/sidebar.js @@ -7,6 +7,7 @@ import type {Element} from './ElementsInspector.js'; import type {PluginClient} from '../../../plugin'; +import type Client from '../../../Client.js'; import type Logger from '../../../fb-stubs/Logger.js'; import Panel from '../Panel.js'; import ManagedDataInspector from '../data-inspector/ManagedDataInspector.js'; @@ -78,6 +79,7 @@ type Props = {| tooltips?: Object, onValueChanged: ?OnValueChanged, client: PluginClient, + realClient: Client, logger: Logger, extensions?: Array, |}; @@ -119,7 +121,12 @@ export class InspectorSidebar extends Component { const sections = (extensions && extensions.map(ext => - ext(this.props.client, element.id, this.props.logger), + ext( + this.props.client, + this.props.realClient, + element.id, + this.props.logger, + ), )) || [];