From 21483986c340cd905089dc3a8c73a2f3d94a039b Mon Sep 17 00:00:00 2001 From: Luke De Feo Date: Tue, 1 Aug 2023 06:41:14 -0700 Subject: [PATCH] Fix bug in tree when search term is set Summary: Previously we would run the effect even if search term hadnt changed causing us to scorll to a search term rather than the selected node when selecting in the visualiser Reviewed By: antonk52 Differential Revision: D47831188 fbshipit-source-id: 5700d49aea219a1229bcc8df462e55d8508c6c1a --- desktop/plugins/public/ui-debugger/components/tree/Tree.tsx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/desktop/plugins/public/ui-debugger/components/tree/Tree.tsx b/desktop/plugins/public/ui-debugger/components/tree/Tree.tsx index 5e126abda..120cfc382 100644 --- a/desktop/plugins/public/ui-debugger/components/tree/Tree.tsx +++ b/desktop/plugins/public/ui-debugger/components/tree/Tree.tsx @@ -114,7 +114,12 @@ export function Tree2({ overscan: 20, }); + const prevSearchTerm = useRef(null); useEffect(() => { + if (prevSearchTerm.current === searchTerm) { + return; + } + prevSearchTerm.current = searchTerm; const matchingIndexes = findSearchMatchingIndexes(treeNodes, searchTerm); if (matchingIndexes.length > 0) {