jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix KState extraction

Browse Source 
Summary:
The field changed from mStates to states breaking our reflection based code. Ideally I would like to just check if type == KStateContainer and access the field normally but the rest of the infrastructure expect to work on a java field.

Added tests to catch this sort of thing in the future. had to shift buck files around a bit to get it to work

Reviewed By: antonk52

Differential Revision: D46974357

fbshipit-source-id: 87a6f5883b33e4d1a7359df5987fc7ead7c19033
This commit is contained in:
Luke De Feo
2023-07-03 12:19:26 -07:00
committed by Facebook GitHub Bot
parent 62cb33b763
commit 20d7b57dbe
2 changed files with 33 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
android/src/main/java/com/facebook/flipper/plugins/uidebugger/model/Inspectable.kt
View File

@@ -35,11 +35,11 @@ sealed class InspectableValue : Inspectable() {
@kotlinx.serialization.Serializable
@SerialName("text")
class Text(val value: String) : InspectableValue()
data class Text(val value: String) : InspectableValue()
@kotlinx.serialization.Serializable
@SerialName("boolean")
class Boolean(val value: kotlin.Boolean) : InspectableValue()
data class Boolean(val value: kotlin.Boolean) : InspectableValue()
@SerialName("number")
@kotlinx.serialization.Serializable