jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Unsubscribe from updates and tidy up

Browse Source 
Summary: Remove listener on unsubscribe and tidy up comments.

Reviewed By: LukeDefeo

Differential Revision: D39575287

fbshipit-source-id: 2b4ac0bc07cfe86f5ad0e602bbba4b596230cd52
This commit is contained in:
Lorenzo Blasa
2022-09-20 05:15:50 -07:00
committed by Facebook GitHub Bot
parent ddc5554673
commit 2051359490
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/ApplicationTreeObserver.kt
View File

@@ -39,15 +39,19 @@ class ApplicationTreeObserver(val context: Context) : TreeObserver<ApplicationRe
} }
} }
context.applicationRef.rootsResolver.attachListener(rootViewListener) context.applicationRef.rootsResolver.attachListener(rootViewListener)
// trigger a traversal on whatever roots we have now // On subscribe, trigger a traversal on whatever roots we have
rootViewListener.onRootViewsChanged(applicationRef.rootViews) rootViewListener.onRootViewsChanged(applicationRef.rootViews)
// TODO: Subscribing to root view changes but not to activity changes.
// Obviously changes in activities have an effect on root views, but
// then it may make sense to unsubscribe the root views listener instead
// of activities.
Log.i(LogTag, "${context.applicationRef.rootViews.size} root views") Log.i(LogTag, "${context.applicationRef.rootViews.size} root views")
Log.i(LogTag, "${context.applicationRef.activitiesStack.size} activities") Log.i(LogTag, "${context.applicationRef.activitiesStack.size} activities")
} }
override fun unsubscribe() { override fun unsubscribe() {
// Not entirely sure this will ever happen or be needed. context.applicationRef.rootsResolver.attachListener(null)
// context.applicationRef.setActivityStackChangedListener(null)
} }
} }