jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use component.className instead of NSStringFromClass"

Browse Source 
Summary: Component classes do not reflect the source of the component anymore.

Reviewed By: fabiomassimo

Differential Revision: D20595754

fbshipit-source-id: 645a63f78ee6aaaf75ac0c1e08bf67229a3f906b
This commit is contained in:
Hugo Cuvillier
2020-04-16 13:47:34 -07:00
committed by Facebook GitHub Bot
parent 8997400071
commit 1ce8a41556
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/CKComponent+Sonar.mm
View File

@@ -109,10 +109,10 @@ static CK::StaticMutex _mutex = CK_MUTEX_INITIALIZER;
auto const canBeReusedCounter = self.flipper_canBeReusedCounter; auto const canBeReusedCounter = self.flipper_canBeReusedCounter;
if (canBeReusedCounter > 0) { if (canBeReusedCounter > 0) {
return [NSString stringWithFormat:@"%@ (Can be reused x%lu)", return [NSString stringWithFormat:@"%@ (Can be reused x%lu)",
NSStringFromClass([self class]), self.className,
(unsigned long)canBeReusedCounter]; (unsigned long)canBeReusedCounter];
} }
return NSStringFromClass([self class]); return self.className;
} }
- (NSString*)sonar_getDecoration { - (NSString*)sonar_getDecoration {

2
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKComponentLayoutWrapper.mm
View File

@@ -94,7 +94,7 @@ static CKFlexboxComponentChild findFlexboxLayoutParams(
_size = layout.size; _size = layout.size;
_position = position; _position = position;
_identifier = [parentKey stringByAppendingString:layout.component _identifier = [parentKey stringByAppendingString:layout.component
? NSStringFromClass([layout.component class]) ? layout.component.className
: @"(null)"]; : @"(null)"];
if (_component && reuseWrapper) { if (_component && reuseWrapper) {