Don't send messages to disconnected clients. Make exportPersistedState compatible with disconnected devices.

Summary:
This diff addresses two problems:

1. Since clients plugins can be active beyond having a connection, we have to make it possible for plugin authors to check if they are connected before they make a call.
2. if there is a custom `exportPersistedState`, plugins should be able to skip making calls if the device has disconnected.

Introducing this change makes it possible to interact with a reasonable level with disconnected clients, and makes it possible to create Flipper traces for disconnected clients.

Note that both items were already problems before supporting offline clients; as there can be a noticeable delay between disconnecting and Flipper detecting that (i've seen up to 30 secs). What happend previously in those cases is that the export would simply hang, as would other user interactions, as loosing the connection in the middle of a process would cause the promise chains to be neither rejected or resolved, which is pretty iffy.

Before this diff, trying to export a disconnected device would hang forever like:

{F369600601}

Reviewed By: nikoant

Differential Revision: D26250895

fbshipit-source-id: 177624a116883c3cba14390cd0fe164e243bb97c
This commit is contained in:
Michel Weststrate
2021-02-09 04:12:09 -08:00
committed by Facebook GitHub Bot
parent 7650ab620d
commit 1bb1cae167
9 changed files with 106 additions and 89 deletions

View File

@@ -45,18 +45,6 @@ export class SandyPluginDefinition {
details: ActivatablePluginDetails;
isDevicePlugin: boolean;
// TODO: Implement T68683476
exportPersistedState:
| ((
callClient: (method: string, params?: any) => Promise<any>,
persistedState: any, // TODO: type StaticPersistedState | undefined,
store: any, // TODO: ReduxState | undefined,
idler?: any, // TODO: Idler,
statusUpdate?: (msg: string) => void,
supportsMethod?: (method: string) => Promise<boolean>,
) => Promise<any /* TODO: StaticPersistedState | undefined */>)
| undefined = undefined;
constructor(
details: ActivatablePluginDetails,
module: FlipperPluginModule<any> | FlipperDevicePluginModule,